Bug 611850

Summary: fix coverity Defect Type: Error handling issues
Product: [Retired] 389 Reporter: Rich Megginson <rmeggins>
Component: Directory ServerAssignee: Rich Megginson <rmeggins>
Status: CLOSED CURRENTRELEASE QA Contact: Chandrasekar Kannan <ckannan>
Severity: medium Docs Contact:
Priority: medium    
Version: 1.2.7CC: benl
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-05-17 14:08:22 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 576869, 639035    
Attachments:
Description Flags
0001-Bug-611850-fix-coverity-Defect-Type-Error-handli.patch nhosoi: review+

Description Rich Megginson 2010-07-06 16:47:29 UTC 
Description of problem:


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:
Comment 2 Rich Megginson 2010-07-06 22:48:18 UTC 
Created attachment 429926 [details]
0001-Bug-611850-fix-coverity-Defect-Type-Error-handli.patch
Comment 3 Rich Megginson 2010-07-06 23:42:04 UTC 
To ssh://git.fedorahosted.org/git/389/ds.git
   7a9c069..85eb921  master -> master
commit 85eb9216d5d4163139a90432084452cf81c8444e
Author: Rich Megginson <rmeggins>
Date:   Tue Jul 6 16:47:45 2010 -0600
    Reviewed by: nhosoi (Thanks!)
    Branch: HEAD
    Fix Description: Check the error return from the functions.  In some cases,
    I was able to figure out that the calling function should perform additional
    error handling (return early, goto error label), but in general the code
    just logs an appropriate error message and continues.  I was able to get
    rid of some more libacl code.  I removed an unused variable from modify.c
    Platforms tested: RHEL5 x86_64
    Flag Day: no
    Doc impact: no