Bug 612979

Summary:	Review Request: celt051 - Celt version for 0.5.1 bitstream format
Product:	[Fedora] Fedora	Reporter:	Alexander Larsson <alexl>
Component:	Package Review	Assignee:	Matthias Clasen <mclasen>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, mclasen, notting
Target Milestone:	---	Flags:	mclasen: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2010-07-09 18:51:57 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Alexander Larsson 2010-07-09 12:54:35 UTC

Spec URL: http://people.gnome.org/~alexl/celt051.spec
SRPM URL: http://people.gnome.org/~alexl/celt051-0.5.1.3-1.fc13.src.rpm
Description:
This is a special version of celt, parallel installable with the main celt package. All filenames and public library symbols have been changed from celt to celt051 (in the upstream tarball, not as a patch).

This is required to build spice, as it depends on this specific version of celt for bitstream compatibility reasons (upstream celt bitstream format is not yet stable, and changes in every release9.

Comment 1 Matthias Clasen 2010-07-09 13:44:17 UTC

Builds fine in mock. rpmlint output:

$ rpmlint /var/lib/mock/fedora-rawhide-x86_64/result/*.rpm
celt051.src: W: spelling-error Summary(en_US) codec -> cosec, codex, code
celt051.src: W: spelling-error %description -l en_US codec -> cosec, codex, code
celt051.src: W: spelling-error %description -l en_US realtime -> mealtime, real time, real-time
celt051.src: W: spelling-error %description -l en_US codecs -> codes, coders, code's
celt051.src: W: spelling-error %description -l en_US bitstream -> bit stream, bit-stream, airstream
celt051.src: W: spelling-error %description -l en_US installable -> install able, install-able, uninstallable
celt051.src: W: spelling-error %description -l en_US particulare -> particulate, particular, particulars
celt051.x86_64: W: spelling-error Summary(en_US) codec -> cosec, codex, code
celt051.x86_64: W: spelling-error %description -l en_US codec -> cosec, codex, code
celt051.x86_64: W: spelling-error %description -l en_US realtime -> mealtime, real time, real-time
celt051.x86_64: W: spelling-error %description -l en_US codecs -> codes, coders, code's
celt051.x86_64: W: spelling-error %description -l en_US bitstream -> bit stream, bit-stream, airstream
celt051.x86_64: W: spelling-error %description -l en_US installable -> install able, install-able, uninstallable
celt051.x86_64: W: spelling-error %description -l en_US particulare -> particulate, particular, particulars
celt051.x86_64: W: no-manual-page-for-binary celtenc051
celt051.x86_64: W: no-manual-page-for-binary celtdec051
4 packages and 0 specfiles checked; 0 errors, 16 warnings.

Those warnings are remarkable for the fact that rpmlint caught an actual spelling error for once: particulare should be particular

The rest can safely be ignored

Comment 2 Matthias Clasen 2010-07-09 13:58:45 UTC

package name: ok, considering this is a special case for parallel installability
spec file name: ok
packaging guidelines: ok, but
   if the package is only destined for f13+, some cleanups are possible:
   - drop BuildRoot
   - drop initial rm -rf in %install
   - drop %clean
license: ok
license field: ok
license file: ok
spec file language: ok
spec file readability: ok
upstream sources: ok
builable: ok
ExcludeArch: ok
BuildRequires: ok
locale handling: ok
ldconfig: ok
system libraries: ok
relocatable: ok
dir ownership: ok
duplicate files: ok; COPYING and README not strictly required in -devel, but ok
file permissions: ok
macro use: ok
content: permissible
large docs: ok
%doc content: ok
headers: ok
static libs: ok
shared libs: ok
devel deps: ok
libtool archives: ok
gui apps: ok
file ownership: ok
utf8 filenames: ok

Please fix the typo in %description.

Approved

Comment 3 Alexander Larsson 2010-07-09 14:08:05 UTC

Updated as:
Spec URL: http://people.gnome.org/~alexl/celt051.spec
SRPM URL: http://people.gnome.org/~alexl/celt051-0.5.1.3-2.fc13.src.rpm

Comment 4 Alexander Larsson 2010-07-09 14:14:15 UTC

New Package CVS Request
=======================
Package Name: celt051
Short Description: An audio codec for use in low-delay speech and audio communication
Owners: alexl
Branches: 
InitialCC:

Comment 5 Kevin Fenzi 2010-07-09 18:24:24 UTC

CVS done (by process-cvs-requests.py).

Comment 6 Matthias Clasen 2010-07-09 18:51:57 UTC

build done