Bug 613031

Summary: initscript: guideline compliance
Product: Red Hat Enterprise Linux 6 Reporter: Ales Zelinka <azelinka>
Component: openwsmanAssignee: Vitezslav Crhonek <vcrhonek>
Status: CLOSED ERRATA QA Contact: Martin Cermak <mcermak>
Severity: medium Docs Contact:
Priority: high    
Version: 6.0CC: dkovalsk, ovasik, syeghiay, ykopkova
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: openwsman-2.2.3-8.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-05-19 13:04:22 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 633349    
Attachments:
Description Flags
RHBA-2011-10472 testing results none

Description Ales Zelinka 2010-07-09 14:55:16 UTC 
Description of problem:
There's few issues with the openwsman's initscript:

According to these guidelines
https://fedoraproject.org/wiki/Packaging/SysVInitScript

The initscript should:

1) return 3 when status of a stopped service is queried:
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
:: [   LOG    ] :: Stop
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

:: [   PASS   ] :: Running 'service openwsmand stop'
:: [   FAIL   ] :: Running 'service openwsmand status' (Expected 3, got 0)
:: [   PASS   ] :: Running 'service openwsmand stop'
:: [   FAIL   ] :: Running 'service openwsmand status' (Expected 3, got 0)


2)PID file:
openwsmand creates pidfile /var/run/wsmand.pid instead of /var/run/openwsmand.pid as defined in the initscript. That itself is not an issue, but might help explain why: the pidfile is not removed when service is stopped.

3) exit code should be 2 when an invalid argument is provided:

::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::
:: [   LOG    ] :: Invalid arguments
::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::::

:: [   FAIL   ] :: Running 'service openwsmand' (Expected 2, got 0)



Version-Release number of selected component (if applicable):
openwsman-server-2.2.3-5.el6.i686
Comment 13 Martin Cermak 2011-03-15 09:08:20 UTC 
Verified manually on stable systems. See testing results [1] above. 

[1] https://bugzilla.redhat.com/show_bug.cgi?id=613031#c12
Comment 14 errata-xmlrpc 2011-05-19 13:04:22 UTC 
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2011-0563.html