Bug 613509

Summary: pm-suspend returned 1
Product: Red Hat Enterprise Linux 6 Reporter: Qian Cai <qcai>
Component: pm-utilsAssignee: Jaroslav Škarvada <jskarvad>
Status: CLOSED CURRENTRELEASE QA Contact: desktop-bugs <desktop-bugs>
Severity: high Docs Contact:
Priority: high    
Version: 6.0CC: jskarvad, rvokal, vbenes
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: pm-utils-1.2.5-8.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-11-10 21:21:17 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 619265    
Bug Blocks:    
Attachments:
Description Flags
Fix maybe_deallocvt, now it returns true if there is --quirk-no-chvt (same behaviour as maybe_chvt). none

Description Qian Cai 2010-07-12 04:51:59 UTC
Description of problem:
This caused hardware test suite (v7) suspend test failure on several laptops (x200, T400).

/var/run/pm-utils/pm-suspend/storage/inhibit was created during the test. The call flow is like this,

pm-suspend
  -> do_suspend
    -> run_hooks sleep 'resume suspend' reverse
       -> maybe_deallocvt
         -> state_exists console 
            -> [ -O "${STORAGEDIR}/state:$1" ]
            (/var/run/pm-utils/pm-suspend/storage/state:console not there)
              -> state_exists console || return (return 1)
                -> hook_exit_status 1
                  -> inhibit
                    -> echo "$*" > "$INHIBIT"
                      -> inhibited
                        -> exit 1

Version-Release number of selected component (if applicable):
kernel-2.6.32-44.el6
pm-utils-1.2.5-7.el6
RHEL6.0-20100707.4

How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Jaroslav Škarvada 2010-07-13 07:34:48 UTC
Created attachment 431375 [details]
Fix maybe_deallocvt, now it returns true if there is --quirk-no-chvt (same behaviour as maybe_chvt).

Happened only on machines with --quirk-no-chvt. Please try the attached patch.

Comment 2 Jaroslav Škarvada 2010-07-13 07:53:23 UTC
Scratch build: https://brewweb.devel.redhat.com/taskinfo?taskID=2590861

Comment 3 Qian Cai 2010-07-13 09:57:30 UTC
It fixed for me. Thanks for the quick fix.

Comment 4 Jaroslav Škarvada 2010-07-14 07:23:49 UTC
Fixed in pm-utils-1.2.5-8.el6.

Comment 5 Vladimir Benes 2010-07-14 09:31:04 UTC
pm-suspend now returns 0 if successfully resumed
-> VERIFIED

Comment 6 releng-rhel@redhat.com 2010-11-10 21:21:17 UTC
Red Hat Enterprise Linux 6.0 is now available and should resolve
the problem described in this bug report. This report is therefore being closed
with a resolution of CURRENTRELEASE. You may reopen this bug report if the
solution does not work for you.