Bug 614298

Summary:	Review Request: emacs-apel - A Portable Emacs Library
Product:	[Fedora] Fedora	Reporter:	Akira TAGOH <tagoh>
Component:	Package Review	Assignee:	Parag AN(पराग) <panemade>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, i18n-bugs, notting, panemade
Target Milestone:	---	Flags:	panemade: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2010-08-03 03:38:52 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Akira TAGOH 2010-07-14 03:41:46 UTC

re-submitting the package review for renaming to meet current packaging policy to apel.

Spec URL: http://tagoh.fedorapeople.org/reviews/emacs-apel/emacs-apel.spec
SRPM URL: http://tagoh.fedorapeople.org/reviews/emacs-apel/emacs-apel-10.8-1.fc14.src.rpm
Description:
APEL (A Portable Emacs Library) is a library to support
to write portable Emacs Lisp programs.

Comment 1 Parag AN(पराग) 2010-07-27 06:46:39 UTC

Review:
+ package builds in mock (rawhide i686).
koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2353361
+ rpmlint output for SRPM and for RPM.
emacs-apel.src: W: no-buildroot-tag
emacs-apel-el.noarch: W: spelling-error Summary(en_US) Elisp -> Elis, Lisp, Elise
emacs-apel-el.noarch: W: spelling-error %description -l en_US elisp -> lisp, e lisp, Elise
emacs-apel-el.noarch: W: obsolete-not-provided apel
emacs-apel-el.noarch: W: no-documentation
3 packages and 0 specfiles checked; 0 errors, 5 warnings.

+ source files match upstream url (sha1sum)
089c18ae006df093aa2edaeb486bfaead6ac4918  apel-10.8.tar.gz
089c18ae006df093aa2edaeb486bfaead6ac4918  apel-10.8.tar.gz.srpm

+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present which is not needed now.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Follow emacs addon packaging guidelines.
+ Not a GUI application

APPROVED.

Suggestions:
1)If package is needed only for F-13 and above then please follow
 a) %clean not needed
 b) cleaning of buildroot at start of %install also not needed

2) See http://koji.fedoraproject.org/koji/getfile?taskID=2353362&name=build.log
I think its good to ask upstream to follow new style in *.el files.

3) installing commands should preserve timestamps. Use
make install PREFIX=$RPM_BUILD_ROOT%{_prefix} \
        LISPDIR=$RPM_BUILD_ROOT%{_emacs_sitelispdir} INSTALL="install -p"

Comment 2 Akira TAGOH 2010-08-02 05:52:42 UTC

Thanks for review.

New Package CVS Request
=======================
Package Name: emacs-apel
Short Description: A Portable Emacs Library
Owners: tagoh
Branches: F-12 F-13 F-14 devel
InitialCC:

Comment 3 Kevin Fenzi 2010-08-02 16:35:22 UTC

GIT done (by process-git-requests).

Comment 4 Akira TAGOH 2010-08-03 03:38:52 UTC

The package has been built into koji.