Bug 615129
| Summary: | Review Request: cjkuni-ukai-fonts - Chinese Unicode TrueType font in Kai face | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Peng Wu <pwu> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | cjkuni-ukai-fonts-0.2.20080216.1-45.fc14 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-09-01 05:49:46 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Peng Wu
2010-07-16 02:07:07 UTC
I see current cjkuni-fonts package in fedora also installs -ghostscript. Is there any reason to drop it? Sorry, open review request for cjkuni-fonts-ghostscript lately. For -ghostscript sub-package, see: Bug 615192 - Review Request: cjkuni-fonts-ghostscript -Chinese Unicode TrueType font ghostscript files New rpm spec for reviewing: Spec URL: http://pwu.fedorapeople.org/cjkuni-ukai-fonts/cjkuni-ukai-fonts.spec SRPM URL: http://pwu.fedorapeople.org/cjkuni-ukai-fonts/cjkuni-ukai-fonts-0.2.20080216.1-44.fc13.src.rpm Here are the change log of new spec according to review comments from cjkuni-uming-fonts: 1. "Obsoletes for cjkunifonts-uming" is removed. 2. INSTALL file is removed. 3. Use %_font_pkg -f *.conf *.ttc now. And new rpm spec for reviewing: Spec URL: http://pwu.fedorapeople.org/cjkuni-ukai-fonts/cjkuni-ukai-fonts.spec SRPM URL: http://pwu.fedorapeople.org/cjkuni-ukai-fonts/cjkuni-ukai-fonts-0.2.20080216.1-45.fc13.src.rpm Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2332714 + rpmlint output for SRPM and for RPM. cjkuni-ukai-fonts.src: W: no-cleaning-of-buildroot %install cjkuni-ukai-fonts.src: W: no-cleaning-of-buildroot %clean cjkuni-ukai-fonts.src: W: no-buildroot-tag cjkuni-ukai-fonts.src: W: no-%clean-section cjkuni-ukai-fonts.noarch: W: obsolete-not-provided cjkuni-fonts-common + source files match upstream url (sha1sum) 70f9489e7e15241c13d7eb6496a38736b49024e6 ttf-arphic-ukai_0.2.20080216.1.orig.tar.gz 70f9489e7e15241c13d7eb6496a38736b49024e6 ttf-arphic-ukai_0.2.20080216.1.orig.tar.gz.srpm + package meets naming guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present which is not needed now. + package installed properly. + Macro use appears rather consistent. + no .pc file present. + no -devel subpackage + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + follows fonts packaging guidelines. APPROVED. New Package CVS Request ======================= Package Name: cjkuni-ukai-fonts Short Description: Chinese Unicode TrueType font in Kai face Owners: pwu Branches: F-13 F-14 InitialCC: petersen i18n-team CVS done (by process-cvs-requests.py). cjkuni-ukai-fonts-0.2.20080216.1-45.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/cjkuni-ukai-fonts-0.2.20080216.1-45.fc14 cjkuni-ukai-fonts-0.2.20080216.1-45.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update cjkuni-ukai-fonts'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/cjkuni-ukai-fonts-0.2.20080216.1-45.fc14 cjkuni-ukai-fonts-0.2.20080216.1-45.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. |