Bug 615192
| Summary: | Review Request: cjkuni-fonts-ghostscript -Chinese Unicode TrueType font ghostscript files | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Peng Wu <pwu> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-08-30 05:16:25 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Peng Wu
2010-07-16 06:12:43 UTC
New rpm spec for reviewing: Spec URL: http://pwu.fedorapeople.org/cjkuni-fonts-ghostscript/cjkuni-fonts-ghostscript.spec SRPM URL: http://pwu.fedorapeople.org/cjkuni-fonts-ghostscript/cjkuni-fonts-ghostscript-0.2.20080216.1-44.fc13.src.rpm According to review comments, fixes license issue. Here are new rpm spec for review: Spec URL: http://pwu.fedorapeople.org/cjkuni-fonts-ghostscript/cjkuni-fonts-ghostscript.spec SRPM URL: http://pwu.fedorapeople.org/cjkuni-fonts-ghostscript/cjkuni-fonts-ghostscript-0.3-1.fc13.src.rpm Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2350726 + rpmlint output for SRPM and for RPM. cjkuni-fonts-ghostscript.src: W: no-cleaning-of-buildroot %install cjkuni-fonts-ghostscript.src: W: no-cleaning-of-buildroot %clean cjkuni-fonts-ghostscript.src: W: no-buildroot-tag cjkuni-fonts-ghostscript.src: W: no-%clean-section => These are not needed to fixed. + source files match upstream url (sha1sum) 08521808c1a1ec4cd12f940a2ae9f53fc0b4c685 cjkuni-fonts-gscid-0.3.tgz 08521808c1a1ec4cd12f940a2ae9f53fc0b4c685 cjkuni-fonts-gscid-0.3.tgz.srpm + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present which is not needed now. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI application Suggestions: 1) looks like license headers in files have text mentioning license is given in COPYING file whereas new upstream tarball provides LICENSE file. Can it be possible to upstream to change reference of COPYING word to LICENSE word in all 6 files? APPROVED. This package has been renamed to ghostscript-chinese. See: [Bug 625678] Review Request: ghostscript-chinese - Ghostscript Chinese fonts configuration files. |