Bug 615291

Summary: rlServiceStart does not start the service
Product: [Fedora] Fedora Reporter: Karel Volný <kvolny>
Component: beakerlibAssignee: Petr Muller <pmuller>
Status: CLOSED ERRATA QA Contact:
Severity: medium Docs Contact:
Priority: low    
Version: 19CC: ohudlick, pmuller, psplicha, qa-errata-list
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: beakerlib-1.9-3.fc20 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-07-30 06:58:01 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1116308, 1116317    

Description Karel Volný 2010-07-16 12:01:44 UTC
Description of problem:
The function rlServiceStart tries to stop the service before starting it, but if stopping fails, the start is skipped then.

Version-Release number of selected component (if applicable):
beakerlib-1.3-2.el4.noarch

How reproducible:
always

Steps to Reproduce:
1. try the test /CoreOS/ypserv/singlehost on RHEL4
  
Actual results:
there's a lot of failures indicating that ypserv service is not running

Expected results:
the test passes

Additional info:
in /usr/share/beakerlib/infrastructure.sh there is:

            if ! service $service stop; then
                rlLogError "rlServiceStart: Stopping service $service failed."
                ((failed++))
                continue
            fi

- the "continue" command causes the next commands, the service startup to be skipped

I see no reason for such behaviour, even if the function thinks that the service is running already (because stopping has failed) then starting a running service should do nothing, no harm trying that

Comment 1 Petr Muller 2010-10-20 15:17:32 UTC
Petr, service stuff is your code, would you look on this? (throw it back on me if not)

Comment 2 Fedora End Of Life 2013-04-03 20:13:53 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 19 development cycle.
Changing version to '19'.

(As we did not run this process for some time, it could affect also pre-Fedora 19 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 19 End Of Life. Thank you.)

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora19

Comment 4 Fedora Update System 2014-06-17 13:42:51 UTC
beakerlib-1.9-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/beakerlib-1.9-1.fc20

Comment 5 Fedora Update System 2014-06-17 23:30:17 UTC
Package beakerlib-1.9-1.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing beakerlib-1.9-1.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-7442/beakerlib-1.9-1.fc20
then log in and leave karma (feedback).

Comment 6 Fedora Update System 2014-07-02 08:02:32 UTC
beakerlib-1.9-2.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/beakerlib-1.9-2.fc20

Comment 7 Dalibor Pospíšil 2014-07-04 08:50:56 UTC
Please consider the package fixing this bug available in Fedora stable repos once bz1116308 is closed and RHEL stable repos once bz1116317 is closed.

Fixed in:
beakerlib-1.9-2.fc19
beakerlib-1.9-2.fc20
beakerlib-1.9-2.fc21
beakerlib-1.9-3.el5
beakerlib-1.9-2.el6
beakerlib-1.9-2.el7

Comment 8 Fedora Update System 2014-07-17 13:16:22 UTC
beakerlib-1.9-3.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/beakerlib-1.9-3.fc20

Comment 9 Fedora Update System 2014-07-30 06:58:01 UTC
beakerlib-1.9-3.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.