Bug 615509

Summary: cluster.rng does not validate the cman_label attribute
Product: Red Hat Enterprise Linux 6 Reporter: Lon Hohberger <lhh>
Component: clusterAssignee: Lon Hohberger <lhh>
Status: CLOSED CURRENTRELEASE QA Contact: Cluster QE <mspqa-list>
Severity: medium Docs Contact:
Priority: low    
Version: 6.0CC: agk, ccaulfie, cfeist, cluster-maint, djansa, extras-orphan, fdinitto, federico.simoncelli, lhh, mbroz, rpeterso, ssaha, swhiteho, teigland
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: cluster-3.0.12-14.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 614356 Environment:
Last Closed: 2010-11-10 19:59:57 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 614356    
Bug Blocks:    
Attachments:
Description Flags
Test case. none

Description Lon Hohberger 2010-07-16 21:17:39 UTC 
+++ This bug was initially created as a clone of Bug #614356 +++

Description of problem:
According to qdisk manual (and qdiskd source code) it is possible to configure the cman_label attribute for the quorumd element:

cman_label="mylabel"
  This overrides the label advertised to CMAN if present.

Although it can not be validated against cluster.rng:

# grep quorumd cluster.conf
<quorumd cman_label="mylabel" interval="1" label="mylabel" tko="4" votes="1"/>

# xmllint -relaxng /usr/share/cluster/cluster.rng cluster.conf > /dev/null 
Relax-NG validity error : Extra element quorumd in interleave
/etc/cluster/cluster.conf:5: element quorumd: Relax-NG validity error : Element cluster failed to validate content
/etc/cluster/cluster.conf fails to validate

Version-Release number of selected component (if applicable):
# rpm -qf /usr/share/cluster/cluster.rng
cman-3.0.12-2.fc13.x86_64

Steps to Reproduce:
1. configure cluster.conf with quorum device and the cman_label attribute
2. update the cluster configuration
  
Actual results:
cluster.conf validation fails

Expected results:
cluster.conf validation should succeed and be updated

Additional info:
This patch should fix the issue:

--- /usr/share/cluster/cluster.rng.orig	2010-05-26 06:51:44.000000000 +0200
+++ /usr/share/cluster/cluster.rng	2010-07-14 10:15:07.000000000 +0200
@@ -280,6 +280,9 @@
         where the quorum device name differs among nodes." rha:sample=""/>
    </optional>
    <optional>
+    <attribute name="cman_label" rha:description="" rha:sample=""/>
+   </optional>
+   <optional>
     <attribute name="status_file" rha:description="" rha:sample=""/>
    </optional>
    <optional>
Comment 1 Lon Hohberger 2010-07-16 21:26:32 UTC 
Created attachment 432507 [details]
Test case.
Comment 2 Lon Hohberger 2010-07-16 21:27:53 UTC 
[lhh@localhost xml]$ ~/cman_label_test.sh ./cluster.rng.in 
testing against ./cluster.rng.in
testing no quorumd...SUCCESS
testing w/ quorumd...SUCCESS
testing w/ cman_label...SUCCESS
Comment 4 Lon Hohberger 2010-07-19 13:37:59 UTC 
http://git.fedorahosted.org/git?p=cluster.git;a=commit;h=7c4cb96ae94033d2608b65f56e705b2280fcfbaf
http://git.fedorahosted.org/git?p=cluster.git;a=commit;h=0a884cdb93b9751598fb6e91598ee9c3c4132fb5
Comment 7 Dean Jansa 2010-08-24 14:58:27 UTC 
[root@marathon-01 ~]# /tmp/432507
testing against /usr/share/cluster/cluster.rng
testing no quorumd...SUCCESS
testing w/ quorumd...SUCCESS
testing w/ cman_label...SUCCESS


Verified using supplied test, thanks Lon!
Comment 8 releng-rhel@redhat.com 2010-11-10 19:59:57 UTC 
Red Hat Enterprise Linux 6.0 is now available and should resolve
the problem described in this bug report. This report is therefore being closed
with a resolution of CURRENTRELEASE. You may reopen this bug report if the
solution does not work for you.