Bug 615575
| Summary: | Review Request: perl-Parse-Method-Signatures - Perl6 like method signature parser | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Iain Arnell <iarnell> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | andrea.veri, fedora-package-review, notting, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://search.cpan.org/dist/Parse-Method-Signatures/ | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-07-20 03:41:17 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Iain Arnell
2010-07-17 09:51:06 UTC
Review: + package builds in mock (rawhide i686). koji Build =>http://koji.fedoraproject.org/koji/taskinfo?taskID=2325443 + rpmlint output for SRPM and for RPM. perl-Parse-Method-Signatures.src: W: no-cleaning-of-buildroot %clean perl-Parse-Method-Signatures.src: W: no-buildroot-tag perl-Parse-Method-Signatures.src: W: no-%clean-section ==> this is due to new guidelines. + source files match upstream url (sha1sum) 1df162eca8fd1b99497f7677b714116ebfb8305c Parse-Method-Signatures-1.003013.tar.gz 1df162eca8fd1b99497f7677b714116ebfb8305c Parse-Method-Signatures-1.003013.tar.gz.srpm + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present which is not needed now. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=3, Tests=344, 2 wallclock secs ( 0.07 usr 0.00 sys + 2.32 cusr 0.08 csys = 2.47 CPU) + Package perl-Parse-Method-Signatures-1.003013-1.fc14.noarch => Provides: perl(Parse::Method::Signatures) = 1.003013 perl(Parse::Method::Signatures::Param) perl(Parse::Method::Signatures::Param::Bindable) perl(Parse::Method::Signatures::ParamCollection) perl(Parse::Method::Signatures::Param::Named) perl(Parse::Method::Signatures::Param::Placeholder) perl(Parse::Method::Signatures::Param::Positional) perl(Parse::Method::Signatures::Param::Unpacked) perl(Parse::Method::Signatures::Param::Unpacked::Array) perl(Parse::Method::Signatures::Param::Unpacked::Hash) perl(Parse::Method::Signatures::Sig) perl(Parse::Method::Signatures::TypeConstraint) perl(Parse::Method::Signatures::Types) Requires: perl(base) perl(Carp) perl(List::MoreUtils) perl(Moose) perl(Moose::Role) perl(Moose::Util::TypeConstraints) perl(MooseX::Types) perl(MooseX::Types::Moose) perl(MooseX::Types::Structured) perl(MooseX::Types::Util) perl(namespace::clean) perl(Parse::Method::Signatures::ParamCollection) perl(Parse::Method::Signatures::Types) perl(PPI) perl(strict) perl(warnings) rpmlib(VersionedDependencies) <= 3.0.3-1 + Not a GUI application APPROVED. New Package CVS Request ======================= Package Name: perl-Parse-Method-Signatures Short Description: Perl6 like method signature parser Owners: iarnell Branches: F-12 F-13 InitialCC: perl-sig CVS done (by process-cvs-requests.py). Thanks for the review. Built and imported in rawhide. Package Change Request ====================== Package Name: perl-Parse-Method-Signatures New Branches: el6 Owners: averi psabata InitialCC: perl-sig Git done (by process-git-requests). |