Bug 616465

Summary: Upgrade JON2.3.1 to JON2.4GA_QA with oracle is adding '|' sign before and after email address of email alert notification
Product: [Other] RHQ Project Reporter: Rajan Timaniya <rtimaniy>
Component: DatabaseAssignee: Joseph Marques <jmarques>
Status: CLOSED CURRENTRELEASE QA Contact: Rajan Timaniya <rtimaniy>
Severity: high Docs Contact:
Priority: urgent    
Version: 3.0.0CC: cwelton, jmarques
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 2.4 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-08-12 16:50:15 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 601949, 614432    
Attachments:
Description Flags
screenshot
none
server log
none
Screenshot of the apparent symptom showing itself, on postgresql, latest build. none

Description Rajan Timaniya 2010-07-20 14:27:33 UTC
Created attachment 433179 [details]
screenshot

Description of problem:
Upgrade JON2.3.1 to JON2.4GA_QA with oracle is adding '|' sign before and after email address of email alert notification.

Version-Release number of selected component (if applicable):
version: 2.4.0.GA_QA  (build #70)
build number: 10856:52c274a

How reproducible:

Steps to Reproduce:
1) Install JON 2.3.1 and agent with Oracle 10g
2) Perform operations on JON 2.3.1
 (i) Create alerts:
       (a) Name:   Platform_alert_test    [Type: Linux (Platform)]
         If Condition:    Free Memory > 0.1B
         Dampening Rule:  Each time condition set is true
         Action Filters:  Disable alert until re-enabled manually or by    
         recovery alert: false
	 Notify Roles (All Resources Role, Super User Role)
         Notify Other Recipients: Eamil - rtimaniy
	 Operation- Control Type:  	View Process List

        (b)Name:   JBOSSAS_JVM_ALERT [Type: JBoss AS JVM (Server)]
         If Condition:    Availability goes DOWN
         Dampening Rule:  Each time condition set is true
         Action Filters:  Disable alert until re-enabled manually or byrecovery 
         alert : false 
	 Notify Roles (All Resources Role, Super User Role)
         Notify Other Recipients: Eamil - rtimaniy

        (c)Name:RHQ_Agent_JVM_Active_Threads_Alert  [Type: RHQ Agent(Server)]
         If Condition:    JVM Active Threads > -1.0
         Dampening Rule:  Each time condition set is true
         Action Filters:  Disable alert until re-enabled manually or byrecovery 
         alert: false 
         Notify Other Recipients: Eamil - rtimaniy
         Notify Roles (All Resources Role, Super User Role)
         Notify JON Users  (username - rhqadmin)

	(d) Name:   RHQ_Agent_alert_test    [Type: RHQ Agent (Server)]
         If Condition:    Total Memory > 0.1B
         Dampening Rule:  Each time condition set is true
         Action Filters:  Disable alert until re-enabled manually or by    
         recovery alert: false
	 Notify Roles (All Resources Role, Super User Role)
         Notify Other Recipients: Eamil - rtimaniy

5) Stop/Down all JON2.3.1 servers
6) Keep all agents running
7) Upgrade one server from JON2.3.1 to JON 2.4 (build #70) (with same database-Oracle 10g)
8) Verify all alert definitions and its email notification values (alert created in JON2.3.1 - step:2)
  
Actual results:
Upgrade JON2.3.1 to JON2.4GA_QA with oracle is adding '|' sign before and after email address of email alert notification.

Expected results:
JON upgrade should not add '|' sign before or after email address of email alert notificaiton.

Additional info:
Please refer attached screenshot and server log.

Comment 1 Rajan Timaniya 2010-07-20 14:28:02 UTC
Created attachment 433180 [details]
server log

Comment 2 Charles Crouch 2010-07-20 15:01:58 UTC
(9:43:00 AM) ccrouch: pilhuhn: https://bugzilla.redhat.com/show_bug.cgi?id=616465 definitely look valid
(9:43:39 AM) pilhuhn: ccrouch: yes, this is different - will have a look at it
(9:45:01 AM) pilhuhn: int configId = persistConfiguration(propertyName, "|" + buffer.toString() + "|");

I can't imagine this is Oracle specific either

Comment 3 Joseph Marques 2010-07-20 15:27:41 UTC
commit e395447b05a549f9771dcc1f2a362dc86c284210
Author: Joseph Marques <joseph>
Date:   Tue Jul 20 11:22:23 2010 -0400

    BZ-616465: fix delimiter for email-based alert notifications

Comment 4 Corey Welton 2010-07-21 04:06:38 UTC
I don't know if this is/was an oracle-only issue, but after installing with the build that should have this fix in it, i am now seeing the same thing occur in postgresql.  Screenshot forthcoming.

Comment 5 Corey Welton 2010-07-21 04:08:50 UTC
Created attachment 433289 [details]
Screenshot of the apparent symptom showing itself, on postgresql, latest build.

Comment 6 Corey Welton 2010-07-21 04:43:28 UTC
Comment on attachment 433289 [details]
Screenshot of the apparent symptom showing itself, on postgresql, latest build.

Nevermind, i had an invalid build.

Comment 7 Corey Welton 2010-07-21 04:45:39 UTC
The pipe symbols are now gone.  QA Verifying.  There are other issues, however...

Comment 8 Corey Welton 2010-08-12 16:50:15 UTC
Mass-closure of verified bugs against JON.