Summary: | Allow editing of attributes matching rules from console | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Retired] 389 | Reporter: | Juan <okelet> | ||||||
Component: | Directory Console | Assignee: | Nathan Kinder <nkinder> | ||||||
Status: | CLOSED CURRENTRELEASE | QA Contact: | Viktor Ashirov <vashirov> | ||||||
Severity: | medium | Docs Contact: | |||||||
Priority: | medium | ||||||||
Version: | 1.2.5 | CC: | amsharma, jgalipea, rmeggins | ||||||
Target Milestone: | --- | ||||||||
Target Release: | --- | ||||||||
Hardware: | All | ||||||||
OS: | Linux | ||||||||
Whiteboard: | |||||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | 2015-12-07 16:53:47 UTC | Type: | --- | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Bug Depends On: | |||||||||
Bug Blocks: | 434915, 495079 | ||||||||
Attachments: |
|
Description
Juan
2010-07-21 09:00:22 UTC
Created attachment 483545 [details]
Patch
Comment on attachment 483545 [details]
Patch
The indentation is off in several places. Otherwise, looks good.
Created attachment 483564 [details]
Revised patch
This cleans up the tabs-vs-spaces indentation problems from the previous patch. Aside from indentation, the code is the same.
Comment on attachment 483564 [details]
Revised patch
ship it
Pushed to master. Thanks to Rich for his review! Counting objects: 31, done. Delta compression using up to 2 threads. Compressing objects: 100% (12/12), done. Writing objects: 100% (16/16), 4.21 KiB, done. Total 16 (delta 10), reused 0 (delta 0) To ssh://git.fedorahosted.org/git/389/ds-console.git 9e2afe5..c95594f master -> master Also, it should be noted that a fix to the ldapjdk is needed for attribute definitions with matching rules to be generated correctly. This ldapjdk bug is logged as 684012. Based on Comment 10, Marking the bug as VERIFIED. |