Bug 616841
Summary: | RFE: Support setting of rx, tx, sg, tso, ufo, gso, gro, lro against physical network interfaces | ||
---|---|---|---|
Product: | Red Hat Enterprise Linux 7 | Reporter: | Daniel Berrangé <berrange> |
Component: | libvirt | Assignee: | Laine Stump <laine> |
Status: | CLOSED WORKSFORME | QA Contact: | Virtualization Bugs <virt-bugs> |
Severity: | medium | Docs Contact: | |
Priority: | low | ||
Version: | 7.0 | CC: | bsarathy, byount, dallan, dyuan, eblake, juzhang, laine, mshao, mst, mzhan, rwu, syeghiay, weizhan, xen-maint, ydu |
Target Milestone: | rc | Keywords: | FutureFeature |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Enhancement | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2013-01-23 19:51:12 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Daniel Berrangé
2010-07-21 14:16:20 UTC
some notes: an additional idea is to make libvirt verify that NIC is compatible with virt, and give the admin hints if it is not. Bug 743176 points out another problem with having LRO turned on on a physical ethernet - when ip_forward is enabled, the device will be reset. Michal, if we take the udev route, what would the design look like? Investigating down a rat hole of BZs, I've found that this has been remedied in the RHEL6 kernel as of 2.6.32-230 (See Bug 772317). The fix is to notice that LRO is turned on when attaching a netdev to a bridge or bond (neither of which support LRO), and simply disable it at that time. This makes perfect sense, since there is no possible reason that having it enabled would be desired. Upstream uses a different mechanism, but the result is the same - if LRO should be disabled for a particular device due to it being attached to some other driver that doesn't support LRO, then it will be automatically disabled. This all means that there is no longer any need for libvirt to provide a mechanism for enabling/disabling LRO, so I'm closing this BZ. |