Bug 617718

Summary: OID field of SNMP trap alert notification getting dropped during database upgrade
Product: [Other] RHQ Project Reporter: John Sanda <jsanda>
Component: DatabaseAssignee: Joseph Marques <jmarques>
Status: CLOSED CURRENTRELEASE QA Contact: John Sanda <jsanda>
Severity: high Docs Contact:
Priority: urgent    
Version: 3.0.0CC: cwelton, rtimaniy
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: 2.4 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-08-12 16:48:36 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 601949    

Description John Sanda 2010-07-23 19:40:05 UTC 
Description of problem:
When I upgraded from 2.3.1 to 2.4.0, I have a few alert definitions with SNMP trap notifications. It appears that the OID fields of the SNMP traps are getting dropped/lost during the database upgrade.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:
Comment 1 Charles Crouch 2010-07-23 22:39:06 UTC 
From joseph:

'this I think can be fixed by changing line 76 of the rhq-serverplugin.xml file to "oid" instead of "OID".  the data should have been properly translated during db-upgrade, but the metadata in the server-side plugin is accessing the wrong property due to case-sensitivity'

John can you try this fix out and if it works, joseph can push the change to release branch.
Comment 2 John Sanda 2010-07-25 01:28:05 UTC 
Tested the change as per Joseph's suggestion locally, and it looked good. I pushed the commit to the release branch.

commit hash: c3b143eec4f67612e868a947f370f1dd7bfc7dee

I will verify when hudson has a build ready.
Comment 3 Heiko W. Rupp 2010-07-26 11:09:55 UTC 
The above change is *not* enough, as the alert sender depends on the name of 
the property too.

Fix is in 0bfff55
Comment 4 Corey Welton 2010-07-27 01:56:19 UTC 
QA Verified -- the values for alerts now persist across an upgrade.  As noted by others earlier, they do /not/ persist from the JON system settings (<2.4) to the JON plugin config (2.4+) level.  As long as we have a docs bug for that, I think we're good to go here.
Comment 5 Corey Welton 2010-08-12 16:48:36 UTC 
Mass-closure of verified bugs against JON.