Bug 618003
| Summary: | urlgrabber raises IOError exceptions without providing proper errno | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Bruno Wolff III <bruno> | ||||
| Component: | python-urlgrabber | Assignee: | James Antill <james.antill> | ||||
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 14 | CC: | james.antill, Jasper.Hartline, mads | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2012-08-16 18:21:03 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 551932 | ||||||
| Attachments: |
|
||||||
This bug appears to have been reported against 'rawhide' during the Fedora 14 development cycle. Changing version to '14'. More information and reason for this action is here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping Is there any more information on this? Bruno, First off - thank you for the detail. If I send a patch here - can you test and confirm that we're covered? Created attachment 442972 [details]
patch for the range error being improperly constructed for an IOError
patch for this attached - let me know if it works. I'll test it, but maybe not real quick. I really need to get a livecd-tools update out this weekend. Bruno, it's not problem - I'm going run some simple tests and commit the patch, for now, since the changes are potentially no big deal. when you get a chance, verifying it would be appreciated. thanks Some comments after looking at content of python-urlgrabber-3.9.1-7.fc13.noarch and the patch:
I think it is unfortunate that urlgrabbers own exceptions inherits from IOError. They _are_ not IOErrors. It is very confusing that we can catch an IOError and see that errno is EBADF - but that it actually means invalid byte range, and that ENOMEM means socket timeout.
I think it would be better to inherit from Exception than from IOError. But OK, for now you probably also have to stay backward compatible ...
Most important right now: byterange.py also contains a
raise IOError('seek from end of file not supported.')
which probably should be something else.
Mads, 1. we cannot easily change it now for fear of what some of the callers are seeing 2. the error being derived from IOError is consistent with what urllib[2] does as well - that is probably where urlgrabber learned it from. 3. this is why a nice test case would make it more pleasant :) This message is a notice that Fedora 14 is now at end of life. Fedora has stopped maintaining and issuing updates for Fedora 14. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At this time, all open bugs with a Fedora 'version' of '14' have been closed as WONTFIX. (Please note: Our normal process is to give advanced warning of this occurring, but we forgot to do that. A thousand apologies.) Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, feel free to reopen this bug and simply change the 'version' to a later Fedora version. Bug Reporter: Thank you for reporting this issue and we are sorry that we were unable to fix it before Fedora 14 reached end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged to click on "Clone This Bug" (top right of this page) and open it against that version of Fedora. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. The process we are following is described here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping |
Description of problem: python-urlgrabber raises IOError exceptions in several places. Either using a string for errno or not providing errno at all. For example (in byterange.py): raise IOError('seek from end of file not supported.') raise IOError, ('ftp error', 'no host given') raise IOError, ('ftp error', msg), sys.exc_info()[2] raise IOError, ('ftp error', reason), sys.exc_info()[2] raise IOError, ('ftp error', reason), sys.exc_info()[2] For the no errno case When this is trapped by code that is expecting there to be both an errno and strerror on the args list this can result in another exception. Also when only argument is supplied e.errno and e.strerror are null. To handle this the exception handler needs not try to reference two arguments, but rather try to use strerror and if that isn't set fallback to arg[0] and hope that is the message. Even using 'ftp error' could potentially cause problems for things that are expecting an error code to be there, not a string. Documentation of IOError exceptions is at: http://docs.python.org/library/exceptions.html#exceptions.EnvironmentError Version-Release number of selected component (if applicable): python-urlgrabber-3.9.1-7.fc13.noarch How reproducible: Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info: