Bug 618104

Summary:	/Ddefine= does not work, unlike native version.
Product:	[Fedora] Fedora	Reporter:	Hin-Tak Leung <htl10>
Component:	mingw32-nsis	Assignee:	Richard W.M. Jones <rjones>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	low
Version:	13	CC:	kevin, lfarkas, rjones
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2010-07-26 07:12:42 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Hin-Tak Leung 2010-07-26 06:44:41 UTC

Description of problem:

Native makensis supports defines via /Ddefine=value and -Ddefine=value, whereas the mingw32-nsis only does -Ddefine=value . /Ddefine=value 
result in error messages like 

Can't open script "/DVERSION=9.00"

Version-Release number of selected component (if applicable):
mingw32-nsis-2.45-3.fc13.x86_64

How reproducible:
always

Steps to Reproduce:
1. Just try one of the examples with /Dsomething= vs -Dsomething=
2.
3.
  
Actual results:


Expected results:


Additional info:
Both dashes and slashes are supposed to be suported since 2.25 in upstream.

Comment 1 Kevin Kofler 2010-07-26 07:12:42 UTC

Slashes as option characters only make sense on platforms which don't use it as path separators. As such, upstream only supports them for native builds. Dashes are supported everywhere.

Comment 2 Richard W.M. Jones 2010-07-26 09:46:34 UTC

I think is at best only a marginal bug.

In any case, it's something that the reporter should pursue with
the upstream NSIS project.  We don't change the option handling
ability of NSIS in any way compared to upstream, AFAIK.

Comment 3 Kevin Kofler 2010-07-26 09:51:02 UTC

Indeed we don't. This is exactly how things work upstream.