Bug 619139

Summary: fsck returns zero instead of error code
Product: Red Hat Enterprise Linux 6 Reporter: Bryn M. Reeves <bmr>
Component: util-linux-ngAssignee: Karel Zak <kzak>
Status: CLOSED ERRATA QA Contact: qe-baseos-daemons
Severity: medium Docs Contact:
Priority: medium    
Version: 6.0CC: azelinka, jmarko, ltroan, rvokal, sct, tao, tumeya
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: util-linux-ng-2.17.2-9.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 618134 Environment:
Last Closed: 2011-05-19 14:05:51 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
fix fsck error handling none

Description Bryn M. Reeves 2010-07-28 16:38:38 UTC 
+++ This bug was initially created as a clone of Bug #618134 +++

Description of problem:
fsck command does not return with proper error code but returns zero under specific circumstance. The return value of fsck_device function should appear as the error code. 

Version-Release number of selected component (if applicable):
e2fsprogs-1.39-23.el5

How reproducible:
Always 

Steps to Reproduce:
1. Create entry such as following to /etc/fstab: 
    /dev/sda1  /data  ignore  defaults  1 2 ###fstype is "ignore"
2. Execute # fsck -t ignore /dev/sdb1 which would return error message. 
3. Execute echo $? to confirm it returned 0 instead of error code. 

  
Actual results:
# echo $? returns 0. 

Expected results:
It should return non-zero, desirably, 8. 

Additional info:
The bug has been encountered by vendor's middle ware, which continued to try running although there were an error.
Comment 1 Eric Sandeen 2010-07-28 16:49:08 UTC 
The "fsck" binary itself is now part of util-linux-ng in rhel6

-ERic
Comment 2 Bryn M. Reeves 2010-07-28 16:59:28 UTC 
Created attachment 435077 [details]
fix fsck error handling

Doh.. Thanks Eric! Here's the patch.
Comment 3 Bryn M. Reeves 2010-07-28 17:05:31 UTC 
Patch in comment #2 is from the partner who reported this, reviewed & localbuild tested by me.
Comment 5 Karel Zak 2010-12-27 21:34:26 UTC 
Fixed by upstream commit 6c6f2af9e3949197cf7a70255895a2f4451f2319. Thanks for the patch!
Comment 7 Bryn M. Reeves 2011-04-13 17:25:05 UTC 
Hmm, I'm a bit puzzled. I can't reproduce the original problem on older el6 versions now. Discussed this a bit with jmarko on irc but haven't had a chance to dig further.
Comment 8 Karel Zak 2011-04-13 23:03:39 UTC 
Upstream commit message:

     fsck: returns proper code on exec() error
    
        # fsck -t foo /dev/sda1; echo $?
        fsck: fsck.foo: not found
        /sbin/fsck: Error 2 while executing fsck.foo for /dev/sda1
        0
    
    new version:
    
        # fsck -t foo /dev/sda1; echo $?
        fsck: fsck.foo: not found
        fsck: Error 2 while executing fsck.foo for /dev/sda1
        8
Comment 12 errata-xmlrpc 2011-05-19 14:05:51 UTC 
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2011-0699.html