Bug 620042

Package Review
==============

Key:
 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format %{name}.spec.
 [x] Package meets the Packaging Guidelines.
 [x] Package successfully compiles and builds into binary rpms on at least one supported architecture.
     Tested on: devel/x86_64
 [x] Rpmlint output:
source RPM:
dvdbackup.src: W: no-buildroot-tag
binary RPM:empty
 [x] Package is not relocatable.
 [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines.
 [!] License field in the package spec file matches the actual license.
     Actual license type: GPLv3+
     License file per spec file: GPLv3
 [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc.
 [x] Spec file is legible and written in American English.
 [!] Sources used to build the package match the upstream source, as provided in the spec URL.
     SHA1SUM of source file from SF: d40b738917cac62a46405f6566a66359504f9a73  dvdbackup-0.4.1.tar.bz2
     SHA1SUM of file included in the src.rpm: 6e0a1c77753160e0e02f48954ac9c4af2ff17433  dvdbackup-0.4.1.tar.bz2
 [x] Package is not known to require ExcludeArch
 [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [x] Package must own all directories that it creates.
 [x] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [x] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -devel subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [x] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI application.
 [x] Package does not own files or directories owned by other packages.
 [x] Final provides and requires are sane.

=== SUGGESTED ITEMS ===
 [x] Latest version is packaged.
 [x] Package does not include license text files separate from upstream.
 [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
     Tested on: koji scratch build for rawhide http://koji.fedoraproject.org/koji/taskinfo?taskID=2369438
 [x] Package should compile and build into binary rpms on all supported architectures.
     Tested on: all archs suported by koji scratch build
 [?] Package functions as described.
 [-] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files is correct.
 [-] File based requires are sane.
 [x] %check is present and the test passes.


=== Issues ===
1. The licenses specified by the sources are GPLv3+ (and LGPL), not GPLv3
[wolfy@wolfy reviews]$ licensecheck /tmp/dvdbackup-0.4.1/*
/tmp/dvdbackup-0.4.1/src/main.c: GPL (v3 or later)
/tmp/dvdbackup-0.4.1/src/dvdbackup.c: GPL (v3 or later)
/tmp/dvdbackup-0.4.1/src/gettext.h: LGPL
/tmp/dvdbackup-0.4.1/src/dvdbackup.h: GPL (v3 or later)


2. The tar.bz2 included in the src.rpm is not identical to the one downloaded with spectool


=== Final Notes ===
You get bonus karma points if you patch the application to compile for EL-6. Now it fails: http://koji.fedoraproject.org/koji/taskinfo?taskID=2369425

Thank you reviewing. The issues above have been fixed.
I will inform the upstream author of the compilation failure on RHEL6.

Spec URL: http://www.byvoid.com/application/dvdbackup/dvdbackup.spec
SRPM URL:
http://www.byvoid.com/application/dvdbackup/dvdbackup-0.4.1-1.fc13.src.rpm
Koji:
dist-f13 http://koji.fedoraproject.org/koji/taskinfo?taskID=2370767

APPROVED

Do you have any other package submitted for review ? Or have you performed any pre-reviews ?

(In reply to comment #4)
> Do you have any other package submitted for review ? Or have you performed any
> pre-reviews ?    

Yes. Opencc: https://bugzilla.redhat.com/show_bug.cgi?id=615577

Chia, I have sponsored you so now you can proceed to request branches to be created for the package.

New Package SCM Request
=======================
Package Name: opencc
Short Description: Libraries for Simplified-Traditional Chinese Conversion
Owners: byvoid
Branches: f12 f13 f14
InitialCC: i18n-team

Sorry, the request above was sent by mistake.

New Package SCM Request
=======================
Package Name: dvdbackup
Short Description: Command line tool for ripping video DVDs
Owners: byvoid
Branches: f12 f13 f14
InitialCC:

Git done (by process-git-requests).

dvdbackup-0.4.1-1.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/dvdbackup-0.4.1-1.fc12

dvdbackup-0.4.1-1.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/dvdbackup-0.4.1-1.fc13

dvdbackup-0.4.1-1.fc14 has been submitted as an update for Fedora 14.
http://admin.fedoraproject.org/updates/dvdbackup-0.4.1-1.fc14

dvdbackup-0.4.1-1.fc13 has been pushed to the Fedora 13 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update dvdbackup'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/dvdbackup-0.4.1-1.fc13

dvdbackup-0.4.1-1.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

dvdbackup-0.4.1-1.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

Package Change Request
======================
Package Name: dvdbackup
New Branches: el6 epel7
Owners: cicku

Git done (by process-git-requests).

dvdbackup-0.4.2-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/dvdbackup-0.4.2-1.el6

dvdbackup-0.4.2-1.el6 has been pushed to the Fedora EPEL 6 stable repository.