Bug 62038
Summary: | qlogic drivers don't fail on unimplemented IOCTLs | ||
---|---|---|---|
Product: | [Retired] Red Hat Linux | Reporter: | Eric Sandeen <sandeen> |
Component: | kernel | Assignee: | Arjan van de Ven <arjanv> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | Brian Brock <bbrock> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | 7.2 | ||
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2004-09-30 15:39:27 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Eric Sandeen
2002-03-26 21:38:08 UTC
2.4.9-31 doesn't support the BLKGETSIZE64 ioctl at all. I understand that it's not supported, but shouldn't it fail if it's not implemented? If "not supported" means "we don't want to hear anything about it" then I understand. :) But if some userspace wants to try BLKGETSIZE64 and fall back to BLKGETSIZE on failure, this won't work on this kernel, because this driver lies about success. Thanks, -Eric Hi Arjan - I don't want to be a pain, just making sure you didn't scan the bug too quickly. :) I understand that BLKGETSIZE64 is not supported in 2.4.9-31 at all. That's why I consider it to be a bug to return success + bogus data when the ioctl is issued. The only way for userspace to know whether a kernel supports an ioctl is to try it, and test for success or failure. The qlogic driver incorrectly reports success, and returns garbage, rather than -EINVAL as it should. This isn't just BLKGETSIZE64, it appears that other unimplemented and/or bogus ioctls will behave the same way, which may indicate a bug in error handling in general. The other scsi drivers don't exhibit this behavior. Thanks, -Eric I'm already investigating this in the driver; I agree it's "not nice". Thanks for the bug report. However, Red Hat no longer maintains this version of the product. Please upgrade to the latest version and open a new bug if the problem persists. The Fedora Legacy project (http://fedoralegacy.org/) maintains some older releases, and if you believe this bug is interesting to them, please report the problem in the bug tracker at: http://bugzilla.fedora.us/ |