Bug 621017

Some notes:

* Unused macros
  - Defined %ruby_sitelib macro seems used nowhere

* License
-------------------------------------------------------------
CC-BY
./website/javascripts/lightbox.js

LGPLv2+
./website/javascripts/rounded_corners_lite.inc.js
-------------------------------------------------------------
  - License tag should be "MIT and CC-BY and LGPLv2+"
    (also see below)

* Requires
  - "R: ruby(abi) = 1.8" is a must item.
  - "rubygem(hoe)" is for development dependency (for
    Rakefile) and is not needed for runtime
    (Also "hoe" is marked as "s.add_development_dependency"
    in installed .gemspec file)
  - lib/scruffy.rb contains:
------------------------------------------------------------
    17  require 'rubygems'
    18  gem 'builder', '>= 2.0'
    19  require 'builder'
------------------------------------------------------------
    So this package should have "Requires: rubygem(builder)".

* Documents
  - I guess the following files / directories can be
    moved to -doc subpackage (after creating -doc subpackage).
    Would you consider this?
----------------------------------------------------------
%{geminstdir}/Rakefile
%{geminstdir}/config
%{geminstdir}/script
%{geminstdir}/spec
%{geminstdir}/test
%{geminstdir}/website
%{geminstdir}/tasks
%{geminstdir}/setup.rb
%{gemdir}/doc/%{gemname}-%{version}
----------------------------------------------------------

* %check
  - As this gem contains spec/ and test/ directories, please
    add %check section and execute some test programs
    ($ rake test and $ rake spec) there.

(In reply to comment #1)
> Some notes:
> 
> * Unused macros
>   - Defined %ruby_sitelib macro seems used nowhere

Removed

> 
> * License
> -------------------------------------------------------------
> CC-BY
> ./website/javascripts/lightbox.js
> 
> LGPLv2+
> ./website/javascripts/rounded_corners_lite.inc.js
> -------------------------------------------------------------
>   - License tag should be "MIT and CC-BY and LGPLv2+"
>     (also see below)

Since these files have been added to the docs package, these additional licenses have only been applied to that.

> 
> * Requires
>   - "R: ruby(abi) = 1.8" is a must item.
>   - "rubygem(hoe)" is for development dependency (for
>     Rakefile) and is not needed for runtime
>     (Also "hoe" is marked as "s.add_development_dependency"
>     in installed .gemspec file)

Changed to a BR(check) dependency.


>   - lib/scruffy.rb contains:
> ------------------------------------------------------------
>     17  require 'rubygems'
>     18  gem 'builder', '>= 2.0'
>     19  require 'builder'
> ------------------------------------------------------------
>     So this package should have "Requires: rubygem(builder)".

Added.

> 
> * Documents
>   - I guess the following files / directories can be
>     moved to -doc subpackage (after creating -doc subpackage).
>     Would you consider this?
> ----------------------------------------------------------
> %{geminstdir}/Rakefile
> %{geminstdir}/config
> %{geminstdir}/script
> %{geminstdir}/spec
> %{geminstdir}/test
> %{geminstdir}/website
> %{geminstdir}/tasks
> %{geminstdir}/setup.rb
> %{gemdir}/doc/%{gemname}-%{version}
> ----------------------------------------------------------

Done

> 
> * %check
>   - As this gem contains spec/ and test/ directories, please
>     add %check section and execute some test programs
>     ($ rake test and $ rake spec) there.    

Done.

Updated:
Spec URL: http://mo.morsi.org/files/gems/rubygem-scruffy.spec
SRPM URL: http://mo.morsi.org/files/gems/rubygem-scruffy-0.2.6-2.fc13.src.rpm

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=2392215

One note:

- If you are not going to import this package into EPEL(5 and below),
  BuildRoot tag is no longer needed:
  https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag

----------------------------------------------------------
   This package (rubygem-scruffy) is APPROVED by mtasaka
----------------------------------------------------------

Would you write SCM request here?

(In reply to comment #4)
> Would you write SCM request here?

Sorry for the delay have been really busy with my main project, deltacloud. See public development here if your interested. 

https://fedorahosted.org/pipermail/deltacloud-devel/

Will devote some more time to Ruby/Rails/Fedora tommorow.

New Package SCM Request
=======================
Package Name: rubygem-scruffy
Short Description: Scruffy is a Ruby library for generating high quality, good looking graphs.
Owners: mmorsi
Branches: f13 f14
InitialCC:

Git done (by process-git-requests).

Would you rebuild this package?

ping again?

Again ping?

Please build this package.

rubygem-scruffy-0.2.6-2.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/rubygem-scruffy-0.2.6-2.fc14

rubygem-scruffy-0.2.6-2.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/rubygem-scruffy-0.2.6-2.fc13

rubygem-scruffy-0.2.6-2.fc14 has been pushed to the Fedora 14 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update rubygem-scruffy'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/rubygem-scruffy-0.2.6-2.fc14

Closing.

rubygem-scruffy-0.2.6-2.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

rubygem-scruffy-0.2.6-2.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.