Bug 621194

==============

Key:
 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
 [x] Package meets the Packaging Guidelines including the Python specific items
 [x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
     tested in: devel/koji
     http://koji.fedoraproject.org/koji/taskinfo?taskID=2379632
 [x] Rpmlint output:
    python-webdav-library.src: W: spelling-error %description -l en_US httplib -> HTTP, halibut, stoplight                   
python-webdav-library.src: W: spelling-error %description -l en_US davlib -> Davis, David, davit                         
python-webdav-library.src: W: spelling-error %description -l en_US versioning -> version, versifying, versification      
python-webdav-library.noarch: W: spelling-error %description -l en_US httplib -> HTTP, halibut, stoplight                
python-webdav-library.noarch: W: spelling-error %description -l en_US davlib -> Davis, David, davit                      
python-webdav-library.noarch: W: spelling-error %description -l en_US versioning -> version, versifying, versification
 [x] Package is not relocatable.
 [x] Buildroot is correct
      {_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 [x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
 [x] License field in the package spec file matches the actual license.
     License type: ASL 2.0 and Python and Public Domain
 [x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
     source package do not have license text
 [x] Spec file is legible and written in American English.
 [x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
304f471910bc61b291e37c5676b42a01425cb20e3f8a88d1e7e5927abf3f672a  Python_WebDAV_Library-0.2.0.zip
304f471910bc61b291e37c5676b42a01425cb20e3f8a88d1e7e5927abf3f672a  /home/msuchy/rpmbuild/SOURCES/Python_WebDAV_Library-0.2.0.zip
 [x] Package is not known to require ExcludeArch
 [x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [x] Package must own all directories that it creates.
 [x] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package has a %clean section, which contains rm -fR $RPM_BUILD_ROOT.
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [x] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -devel subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [-] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
 [x] Package does not own files or directories owned by other packages.

=== SUGGESTED ITEMS ===
 [x] Latest version is packaged.
 0.2.0
 [x] Package does not include license text files separate from upstream.
 [-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
     Tested on: koji scratch build
 [x] Package should compile and build into binary rpms on all supported
architectures.
     Tested on:koji scratch build
 [?] Package functions as described.
 [-] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files is correct.
 [-] File based requires are sane.
 [-] %check is present and the tests pass


================
*** APPROVED ***
================

Thanks for the review.

New Package CVS Request
=======================
Package Name: python-webdav-library
Short Description: Object-oriented Python WebDAV client-side library
Owners: sochotni
Branches: devel f14 f13 f12
InitialCC:

Git done (by process-git-requests).

> Requires(pre):       python-icalendar

So, you've sneaked in that explicit dependency post review :-( without commenting on it here during review and not in the package %changelog either, and it's an unresolvable dependency for F12, F13 and F14 for more than two weeks.

Is anything being done to resolve this?

(In reply to comment #4)
> > Requires(pre):       python-icalendar
> 
> So, you've sneaked in that explicit dependency post review :-( without
> commenting on it here during review and not in the package %changelog either,
> and it's an unresolvable dependency for F12, F13 and F14 for more than two
> weeks.
> 
> Is anything being done to resolve this?

Sorry, I made a mistake when importing SRPM. I had been testing use of Requires and Requires(pre) for completely unrelated reasons, and then my vacation started so I wasn't able to fix this until now. Pushing update now. I wouldn't guess this new package would get users so fast :-)

python-webdav-library-0.2.0-2.fc12 has been submitted as an update for Fedora 12.
http://admin.fedoraproject.org/updates/python-webdav-library-0.2.0-2.fc12

python-webdav-library-0.2.0-2.fc14 has been submitted as an update for Fedora 14.
http://admin.fedoraproject.org/updates/python-webdav-library-0.2.0-2.fc14

python-webdav-library-0.2.0-2.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/python-webdav-library-0.2.0-2.fc13

python-webdav-library-0.2.0-2.fc14 has been pushed to the Fedora 14 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update python-webdav-library'.  You can provide feedback for this update here: http://admin.fedoraproject.org/updates/python-webdav-library-0.2.0-2.fc14

python-webdav-library-0.2.0-2.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.

python-webdav-library-0.2.0-2.fc12 has been pushed to the Fedora 12 stable repository.  If problems still persist, please make note of it in this bug report.

python-webdav-library-0.2.0-2.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.