Bug 621199
| Summary: | Can't add new printer | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Pavel Stehlik <pstehlik> | ||||
| Component: | system-config-printer | Assignee: | Tim Waugh <twaugh> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | low | ||||||
| Version: | 13 | CC: | dsladmin, gilles.gagniard, jpopelka, maurizio.antillon, twaugh | ||||
| Target Milestone: | --- | ||||||
| Target Release: | --- | ||||||
| Hardware: | x86_64 | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | system-config-printer-1.2.5-6.fc13 | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2010-11-22 22:14:04 UTC | Type: | --- | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
|
Description
Pavel Stehlik
2010-08-04 13:58:46 UTC
User was adding host-name of a printer like socket://canon-printer.brq.redhat.com which resolved as socket://socket://canon-printer.brq.redhat.com:9100 device-uri. We should probably better check correctness of typed-in ip-address/hostname. Or maybe could be replaced label "Host:" to "socket://" front of textbox. 'socket://' is the text it is, and is not translatable. 'Host:' on the other hand can be translated into something suitable for each language. The correct solution is for system-config-printer to disallow the ':' and '/' characters I think. One way to do this is by connecting to the 'changed' signal for that Entry object, like we do for entNPName. Created attachment 449255 [details]
patch
Tim, can you check this one ?
And I'm not sure whether this will go into 1.2 or 1.3 ?
Looks great, thanks. This can go into 1.2.x. system-config-printer-1.2.5-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/system-config-printer-1.2.5-1.fc14 system-config-printer-1.2.5-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/system-config-printer-1.2.5-1.fc13 system-config-printer-1.2.5-1.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update system-config-printer'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/system-config-printer-1.2.5-1.fc13 Regarding patch indicated via comment 10 - eror - Cups server error : There was an error during the CUPS operation: 'client-error-not-possible'. Info in console indicates that a smb.conf is expected in /root/.smb/smb.conf: If this is manually added it appears that it still expects a preconfiguration for the printer being added. Traceback - params.c:OpenConfFile() - Unable to open configuration file "/root/.smb/smb.conf": No such file or directory params.c:OpenConfFile() - Unable to open configuration file "/root/.smb/smb.conf.append": No such file or directory Caught non-fatal exception. Traceback: File "/usr/share/system-config-printer/system-config-printer.py", line 5571, in on_btnSMBVerify_clicked os.O_RDWR, 0777) NoEntryError: (2, 'No such file or directory') Continuing anyway.. No ID match for device smb://hp7500/HP-CP1215: MFG:Generic;MDL:Printer;DES:Generic Printer; Using textonly.ppd (status: 3) This just indicates that the share is not accessible. The "/root/.smb/..." messages come from libsmbclient. When trying to open the URI "smb://hp7500/HP-CP1215", the libsmbclient library returned an error code indicating that it does not exist or cannot find it. That message is unrelated to "client-error-not-possible", which indicates some other sort of problem. Can you expand any more on what went wrong? FC14; system-config-printer-1.2.5-3.fc14.x86_64; Now is impossible enter chars like /';:%^& into HOST field. Then solved, thank you. I'm also impacted by this bug, while trying to add a new SMB remote printer. Here is what I get from CUPS error logs : E [12/Nov/2010:10:33:02 +0100] Returning IPP client-error-not-possible for CUPS-Add-Modify-Printer (ipp://localhost/printers/Canon-imageRunner-C5800) from localhost E [12/Nov/2010:10:33:02 +0100] Returning HTTP Forbidden for CUPS-Add-Modify-Printer (ipp://localhost/printers/Canon-imageRunner-C5800) from localhost E [12/Nov/2010:10:33:09 +0100] Returning IPP client-error-not-possible for CUPS-Add-Modify-Printer (ipp://localhost/printers/Canon-imageRunner-C5800) from localhost E [12/Nov/2010:10:33:11 +0100] Returning IPP client-error-not-possible for CUPS-Add-Modify-Printer (ipp://localhost/printers/Canon-imageRunner-C5800) from localhost Of course, adding printer manually works perfectly. Dirk and Gilles: it sounds like the problem you are both experiencing is entirely different to this one (of using a device URI like socket://socket://...). Please file a separate bug report. Use 'cupsctl --debug-logging' to enable extra logging, then try adding the printer, and attach to the new bug report any log messages you get. Use 'cupsctl --no-debug-logging' to turn off extra logging. system-config-printer-1.2.5-6.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. system-config-printer-1.2.5-6.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. |