Bug 621242

Summary:	Review Request: gyp - Generate Your Projects
Product:	[Fedora] Fedora	Reporter:	Akira TAGOH <tagoh>
Component:	Package Review	Assignee:	Mamoru TASAKA <mtasaka>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, i18n-bugs, notting
Target Milestone:	---	Flags:	mtasaka: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2010-08-06 07:08:13 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	619395

Description Akira TAGOH 2010-08-04 15:09:55 UTC

Spec URL: http://tagoh.fedorapeople.org/reviews/gyp/gyp.spec
SRPM URL: http://tagoh.fedorapeople.org/reviews/gyp/gyp-0.1-0.1.839svn.fc12.src.rpm
Description:
GYP is a tool to generates native Visual Studio, Xcode and SCons
and/or make build files from a platform-independent input format.

Its syntax is a universal cross-platform build representation
that still allows sufficient per-platform flexibility to accommodate
irreconcilable differences.

Comment 1 Mamoru TASAKA 2010-08-04 18:34:36 UTC

Some notes:

! Unneeded macros
  - You can remove %python_sitearch definition because it is uses nowhere.

* Release
--------------------------------------------------------
Release:	0.1.%{?revision:%{revision}svn}%{?dist}
--------------------------------------------------------
  - Well, I guess you meant "0.1%{?revision:.%{revision}svn}%{?dist}"

* BuildRoot
  - BuildRoot tag is no longer needed on Fedora and EPEL6:
    https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag

* BR for python
  - Please specify python2 or python3. ref:
    https://fedoraproject.org/wiki/Packaging/Python#BuildRequires

  - Build fails on F-12 without BR: python2-devel:
    http://koji.fedoraproject.org/koji/taskinfo?taskID=2379955

* %{__python} setup.py install
  - Maybe there is only small difference, however I guess we usually
    add "--skip-build" to "python setup.py install".

Comment 2 Akira TAGOH 2010-08-05 03:00:53 UTC

(In reply to comment #1)
> Some notes:
> 
> ! Unneeded macros
>   - You can remove %python_sitearch definition because it is uses nowhere.

It was necessary to build on f12:
https://fedoraproject.org/wiki/Packaging:Python#Macros

> * Release
> --------------------------------------------------------
> Release: 0.1.%{?revision:%{revision}svn}%{?dist}
> --------------------------------------------------------
>   - Well, I guess you meant "0.1%{?revision:.%{revision}svn}%{?dist}"

You're right. fixed.

> 
> * BuildRoot
>   - BuildRoot tag is no longer needed on Fedora and EPEL6:
>     https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag

fixed.

> 
> * BR for python
>   - Please specify python2 or python3. ref:
>     https://fedoraproject.org/wiki/Packaging/Python#BuildRequires
> 
>   - Build fails on F-12 without BR: python2-devel:
>     http://koji.fedoraproject.org/koji/taskinfo?taskID=2379955

Okay, fixed.

> * %{__python} setup.py install
>   - Maybe there is only small difference, however I guess we usually
>     add "--skip-build" to "python setup.py install".    

Sure. updated with:
Spec URL: http://tagoh.fedorapeople.org/reviews/gyp/gyp.spec
SRPM URL: http://tagoh.fedorapeople.org/reviews/gyp/gyp-0.1-0.2.839svn.fc12.src.rpm

Comment 3 Mamoru TASAKA 2010-08-05 07:44:22 UTC

Okay.

(In reply to comment #2)
> (In reply to comment #1)
> > Some notes:
> > 
> > ! Unneeded macros
> >   - You can remove %python_sitearch definition because it is uses nowhere.
> 
> It was necessary to build on f12:
> https://fedoraproject.org/wiki/Packaging:Python#Macros

- Well, what I meant here is while %python_sitelib definition is
  needed for F=12, %python_sitearch definition is unneeded (because
  this is noarch), however not a blocker.

---------------------------------------------------------------
    This package (gyp) is APPROVED by mtasaka
---------------------------------------------------------------

Comment 4 Akira TAGOH 2010-08-05 08:17:53 UTC

Ah, yep. just copy and paste that there. anyway, thank you for the review.

New Package SCM Request
=======================
Package Name: gyp
Short Description: Generate Your Projects
Owners: tagoh
Branches: f12 f13 f14
InitialCC:

Comment 5 Kevin Fenzi 2010-08-05 17:12:04 UTC

Git done (by process-git-requests).

Comment 6 Akira TAGOH 2010-08-06 07:08:13 UTC

Thanks. the packages has been built.

Comment 7 Akira TAGOH 2011-08-24 03:35:46 UTC

Package Change Request
======================
Package Name: gyp
New Branches: el5 el6
Owners: tagoh
InitialCC:

Comment 8 Gwyn Ciesla 2011-08-24 09:58:59 UTC

Git done (by process-git-requests).

Comment 9 Akira TAGOH 2014-03-05 03:51:38 UTC

Package Change Request
======================
Package Name: gyp
New Branches: epel7
Owners: tagoh

Comment 10 Gwyn Ciesla 2014-03-06 13:20:15 UTC

Git done (by process-git-requests).