Bug 621482

Kevin, any updates on this?

Dor,
This should be pretty easy (I hope) and would enable us to report progress back
up which currently we cannot.

Can this be done for 6.1?

Kevin, can you do it?

Sounds doable for 6.1. However, to be really useful, it needs to be implemented in the tools, too, so probably it must be done relatively early?

And just to ensure that we're talking about the same operations, this is about convert and rebase, right? Any other operation I forgot?

(In reply to comment #5)
> Sounds doable for 6.1. However, to be really useful, it needs to be implemented
> in the tools, too, so probably it must be done relatively early?
preferably, yes

> 
> And just to ensure that we're talking about the same operations, this is about
> convert and rebase, right? Any other operation I forgot?

you forgot commit

Any update on this?

No update, I have been occupied with other things.

Hi,

We need clarification as to which commands you are looking for
progress support for. Some commands are relatively easy to add
support for, in particular 'convert' and 'rebase' since they are
contained in qemu-img.c. Other commands like 'create' require
changes to the format driver, which will be much harder to justify
to get into upstream.

Thanks,
Jes

We would like to have progress for everything. But long running operations like convert and rebase will benefit more from this feature.

Some commands are more complicated to report progress from than others.

However, for the format, what is suitable - can you handle progress
being printed to stdout and updated like it does for fsck etc?

I would prefer it being reported to stderr dd style
by sending sigusr1 I'll be able to see the current progress state

Hmmm ok, the original request said any style. I have posted an additional
patch upstream that provides SIGUSR1 reporting similar to dd, on top of the
-p flag that was already accepted.

If it gets accepted, I will look at back porting it to RHEL6.2

since this issue is a RFE ,so no need to reproduce it 
Verified it on 

1. man qemu-img
2. qemu-img --help
3. qemu-img convert  -p -f raw -O qcow2 winxp winxp.qcow2
4. # qemu-img rebase -f qcow2 -b winxp -F raw winxp.sp2 -p
    (0.00/100%)

Actual Results:
after step1 ,-p listed in man page 
after step2 ,-p listed in help
after step3 ,there is progress of qemu-img (100.00/100%)
after step4 ,there is progress of qemu-img ((6.01/100%)

Based on above this issue has been fixed already.

(In reply to comment #24)
> since this issue is a RFE ,so no need to reproduce it 
> Verified it on 
> 
> 1. man qemu-img
> 2. qemu-img --help
> 3. qemu-img convert  -p -f raw -O qcow2 winxp winxp.qcow2
> 4. # qemu-img rebase -f qcow2 -b winxp -F raw winxp.sp2 -p
>     (0.00/100%)
> 
> Actual Results:
> after step1 ,-p listed in man page 
> after step2 ,-p listed in help
> after step3 ,there is progress of qemu-img (100.00/100%)
> after step4 ,there is progress of qemu-img ((6.01/100%)
> 
> Based on above this issue has been fixed already.

Also need to test this with SIGUSR1, i.e.
run:
qemu-img convert -f raw -O qcow2 winxp winxp.qcow2 &
(make sure winxp is big so this will take a long time)
send SIGUSR1 every 5s

(In reply to comment #25)

> Also need to test this with SIGUSR1, i.e.
> run:
> qemu-img convert -f raw -O qcow2 winxp winxp.qcow2 &
> (make sure winxp is big so this will take a long time)
> send SIGUSR1 every 5s

steps:
1.qemu-img convert -f raw -O qcow2 winxp winxp.qcow2 &
# for ((;;))
> do kill -SIGUSR1 `pidof qemu-img`
> sleep 5
> done
    (14.05/100%)
    (16.06/100%)
    (18.07/100%)
    (20.08/100%)
    (22.09/100%)
    (72.28/100%)
based on above and comment #24 ,this issue has been fixed ald.

Ayal,Thanks for your reminder.I will read patch(es) first when verify bug.

    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
There was no way to know the completion percentage of a qemu-img command.

A '-p' option was added to qemu-img to make it print progress information while running.

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2011-1531.html