Bug 621752

Summary:	kernel: USB: fix testing the wrong variable in fs_create_by_name() [mrg-1]
Product:	Red Hat Enterprise MRG	Reporter:	Eugene Teo (Security Response) <eteo>
Component:	realtime-kernel	Assignee:	Red Hat Real Time Maintenance <rt-maint>
Status:	CLOSED CURRENTRELEASE	QA Contact:	David Sommerseth <davids>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	Development	CC:	bhu, eteo, lgoncalv, ovasik, williams
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	594630	Environment:
Last Closed:	2012-01-06 07:49:29 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	594630
Bug Blocks:

Description Eugene Teo (Security Response) 2010-08-06 03:23:05 UTC

There is a typo here.  We should be testing "*dentry" which was just assigned instead of "dentry".  This could result in dereferencing an ERR_PTR inside either usbfs_mkdir() or usbfs_create().

Upstream commit:
http://git.kernel.org/linus/fa7fe7af146a7b613e36a311eefbbfb5555325d1

Comment 1 Clark Williams 2012-01-05 23:16:41 UTC

Not sure how this slipped by. We have the above commit in our current MRG 2.0 tree since v2.6.33.4-rt21. 

Ok to close with CURRENTRELEASE?

Comment 2 Eugene Teo (Security Response) 2012-01-06 07:49:29 UTC

OK