Bug 622270
| Summary: | Review Request: elementary-icon-theme - icons from the Elementary Project | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tajidin Abdullah <tajidinabd> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora, fedora-package-review, gracca, notting |
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-08-25 18:33:19 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Tajidin Abdullah
2010-08-08 14:27:07 UTC
Also like to include a link to successful koji build with the srpm https://koji.fedoraproject.org/koji/taskinfo?taskID=2388159 (Removing NEEDSPONSOR) Made corrections to intial submission due to scriplets omission and tarname macro. However having problem with documentation Spec Url: http://tajidinabd.fedorapeople.org/elementary-icon-theme/elementary-icon-theme.spec Srpm Url: http://tajidinabd.fedorapeople.org/elementary-icon-theme/elementary-icon-theme-2.4-2.fc13.src.rpm successful koji scratch http://koji.fedoraproject.org/koji/taskinfo?taskID=2388541 made more corrections to the spec file cleaned a few issues in regards to the prep and clarified issue with the version number also still looking for guidance about the %doc i know in fedora documentation is needed. but i couldnt get it to build with the documentation. any help on this issue thank you spec url: http://tajidinabd.fedorapeople.org/elementary-icon-theme/elementary-icon-theme.spec srpm url: http://tajidinabd.fedorapeople.org/elementary-icon-theme/elementary-icon-theme-2.4-3.fc13.src.rpm Add the following line:
%doc elementary/{AUTHORS,CONTRIBUTORS,COPYING}
(not tested!)
Regards,
Germán.
waiting for response from upstream in regards to changing name of source package to reflect version number. yes that tip did work German thanks for that. Some notes:
* License tag
- From elementary-monochrome/AUTHORS:
---------------------------------------------------
8 This package is licensed under GNU General Public License version 2.
---------------------------------------------------
From elementary/AUTHORS:
---------------------------------------------------
8 This package is licensed under GNU General Public License version 2.
---------------------------------------------------
Therefore the license tag should be "GPLv2".
* Timestamps
- Please use "cp -a" instead of "cp -R" to keep timestamps on installed
files as much as possible:
https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps
* Documentation
- I think
---------------------------------------------------
elementary-monochrome/AUTHORS
elementary-monochrome/COPYING
elementary/AUTHORS
elementary/CONTRIBUTORS
elementary/COPYING
---------------------------------------------------
should also be installed as %doc and be installed under %_defaultdocdir.
The example would be
---------------------------------------------------
At %prep:
mkdir -p doc/elementary{,-monochrome}
cp -p elementary-monochrome/[A-Z]* doc/elementary-monochrome/
cp -p elementary/[A-Z]* doc/elementary/
And at %files:
%doc doc/*
---------------------------------------------------
made changes to spec accordingly with the license, timestamps, and documentation spec URL: http://tajidinabd.fedorapeople.org/elementary-icon-theme/elementary-icon-theme.spec srpm URL: http://tajidinabd.fedorapeople.org/elementary-icon-theme/elementary-icon-theme-2.4-5.fc13.src.rpm thanks for the review For -5:
* Directory ownership issue
- Now the following directories (themselves) are not owned by any packages
----------------------------------------------------------
%{_datadir}/icons/elementary/
%{_datadir}/icons/elementary-monochrome/
----------------------------------------------------------
These directories should be owned by this rpm. Please refer
to
https://fedoraproject.org/wiki/Packaging/Guidelines#File_and_Directory_Ownership
https://fedoraproject.org/wiki/Packaging/UnownedDirectories#Wildcarding_Files_inside_a_Created_Directory
Spec Url: http://tajidinabd.fedorapeople.org/elementary-icon-theme/elementary-icon-theme.spec Srpm Url: http://tajidinabd.fedorapeople.org/elementary-icon-theme/elementary-icon-theme-2.4-6.fc13.src.rpm made corrections per previous comments Okay. ------------------------------------------------------------------ This package (elementary-icon-theme) is APPROVED by mtasaka ------------------------------------------------------------------ New Package SCM Request ======================= Package Name: elementary-icon-theme Short Description: icons from the Elementary Project Owners: tajidinabd Branches: f12 f13 f14 InitialCC: Git done (by process-git-requests). Closing. *** Bug 693375 has been marked as a duplicate of this bug. *** |