Bug 622875

Created attachment 437936 [details]
test code

Description of problem: Using manual message acknowledgment along with a recommended solution (provided by Red Hat) for another problem I found a scenario in which the message listener stops receiving messages.

We implemented the following solution that was recommended by Red Hat contained in Issue 501213:

// Recommeneded solution
subscriptions_ = new SubscriptionManager( session );
SubscriptionSettings settings;
settings.flowControl = FlowControl::messageWindow(1000);
settings.autoAck = 100;
subscriptions_->subscribe( *this, "message_queue",
                          settings );
std::cout << "Subscribed through failover mgr, calling run()!" << std::endl;
subscriptions_->run();
---
This fixed the origonal problem from Issue 501213, but
I noticed while performing some tests that if my message receiver receives 1000 message (the same value that was set for the message window) and rejects all 1000 messages that the message receiver no longer receives additional messages.  I tried changing the message window to various sizes but I still received the same results after the same number of messages as was set for the window size were received and rejected sequentially.

How reproducible:

Steps to Reproduce:
1. Create a message listener with the following subscription settings:

SubscriptionSettings settings;
settings.flowControl = FlowControl::messageWindow(1);
settings.autoAck = 100;
settings.acquireMode = qpid::client::ACQUIRE_MODE_PRE_ACQUIRED;

2. In the message listeners received() method reject the message: Ex:

class MyMessageListener : public MessageListener
{
   private:
       Session& session_;

   public:
   MyMessageListener(Session& session)
       : session_(session) {}
 
   void
   MyMessageListener::received(Message& message)
   {
       cout << "Received message" << endl;
       session_.release(message); // reject the message
   }
};

3. Send two messages to the listener.

Actual results:
The message listener will only receive one of the two messages and will print the string "Received message" once, at which point it will hang.

Expected results:
The message receiver should continue to receive both messages indefinitely, causing the message "Received message" to be continuously printed to standard out.