Bug 623863

Summary: python-krbV uses PyCObject API (deprecated in Python 2.7)
Product: [Fedora] Fedora Reporter: Dave Malcolm <dmalcolm>
Component: python-krbVAssignee: Mike Bonnet <mikeb>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: 14CC: mikeb
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-08-16 19:29:09 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 620842    
Attachments:
Description Flags
Initial attempt at a patch for this (doesn't yet compile) none

Description Dave Malcolm 2010-08-13 01:16:19 UTC 
Description of problem:
Python 2.7 deprecated the PyCObject API in favor of a new "capsule" API.
  http://docs.python.org/dev/whatsnew/2.7.html#capsules

The deprecations are set to "ignore" by default, so in theory the API still works.

However the deprecation has caused at least one app to fail (virt-manager, see bug 620216, due to it modifying the warning settings), so I've been doublechecking the scope of usage of the PyCObject API, and am filing bugs against components that are possibly affected.

You can trigger a hard failure of the API via:
>>> import warnings
>>> warnings.filterwarnings('error')
>>> import krbV
>>> krbV.AuthContext()
python: krb5module.c:69: Context_init: Assertion `cobj' failed.
Aborted

I'm not yet sure what the best approach is to fixing this.


Version-Release number of selected component (if applicable):
python-krbV-1.0.90-2.fc14.src.rpm

Grepping the source tree shows that it uses PyCObject extensively:

./python-krbV-1.0.90/krb5module.c:68:      cobj = PyCObject_FromVoidPtr(ctx, (void (*)(void*))krb5_free_context);
./python-krbV-1.0.90/krb5module.c:108:      kctx = PyCObject_AsVoidPtr(ctx);
./python-krbV-1.0.90/krb5module.c:166:      kctx = PyCObject_AsVoidPtr(ctx);
./python-krbV-1.0.90/krb5module.c:236:  kctx = PyCObject_AsVoidPtr(ctx);
./python-krbV-1.0.90/krb5module.c:297:  kctx = PyCObject_AsVoidPtr(ctx);
./python-krbV-1.0.90/krb5module.c:363:  kctx = PyCObject_AsVoidPtr(ctx);
./python-krbV-1.0.90/krb5module.c:520:  kctx = PyCObject_AsVoidPtr(ctx);
./python-krbV-1.0.90/krb5module.c:561:  ccache = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:570:      pclient = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:589:      pserver = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:614:      ac_out = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:641:      otmp = PyCObject_FromVoidPtrAndDesc(ac_out, kctx, destroy_ac);
./python-krbV-1.0.90/krb5module.c:684:  otmp = PyCObject_FromVoidPtrAndDesc(princ, ctx, destroy_principal);
./python-krbV-1.0.90/krb5module.c:891:  kctx = PyCObject_AsVoidPtr(ctx);
./python-krbV-1.0.90/krb5module.c:898:      ac_out = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:912:      kt = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:922:      pserver = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:943:      otmp = PyCObject_FromVoidPtrAndDesc(ac_out, kctx, destroy_ac);
./python-krbV-1.0.90/krb5module.c:1099:  kctx = PyCObject_AsVoidPtr(ctx);
./python-krbV-1.0.90/krb5module.c:1119:  ccache = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:1127:      pclient = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:1140:      pserver = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:1184:    otmp = PyCObject_FromVoidPtrAndDesc(ac_out, kctx, destroy_ac);
./python-krbV-1.0.90/krb5module.c:1275:  kctx = PyCObject_AsVoidPtr(ctx);
./python-krbV-1.0.90/krb5module.c:1293:  kt = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:1302:      pserver = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:1346:    otmp = PyCObject_FromVoidPtrAndDesc(ac_out, kctx, destroy_ac);
./python-krbV-1.0.90/krb5module.c:1404:  kctx = PyCObject_AsVoidPtr(ctx);
./python-krbV-1.0.90/krb5module.c:1414:  ac = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:1476:  kctx = PyCObject_AsVoidPtr(ctx);
./python-krbV-1.0.90/krb5module.c:1485:  ac = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:1611:	ctx = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:1615:      ac = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:1717:	    ctx = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:1721:	ac = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:1748:      rcache = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:1882:	ctx = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:1890:    ac = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:1950:	ctx = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:1958:    ac = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:2013:				  &conobj, &PyCObject_Type, &acobj))
./python-krbV-1.0.90/krb5module.c:2021:  ctx = PyCObject_AsVoidPtr(cobj);
./python-krbV-1.0.90/krb5module.c:2035:	cobj = PyCObject_FromVoidPtrAndDesc(ac, ctx, destroy_ac);
./python-krbV-1.0.90/krb5module.c:2090:  ctx = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:2092:  ac = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:2180:	    ctx = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:2184:	princ = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:2256:	    ctx = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:2260:	princ = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:2339:  ctx = PyCObject_AsVoidPtr(cobj);
./python-krbV-1.0.90/krb5module.c:2347:  else if(PyCObject_Check(princobj))
./python-krbV-1.0.90/krb5module.c:2365:	cobj = PyCObject_FromVoidPtrAndDesc(princ, ctx, destroy_principal);
./python-krbV-1.0.90/krb5module.c:2411:	ctx = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:2419:    princ = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:2466:	ctx = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:2470:    princ = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:2508:	ctx = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:2511:  princ = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:2513:  otherprinc = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:2548:	ctx = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:2552:    princ = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:2639:	    ctx = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:2643:	ccache = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:2713:	    ctx = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:2717:	ccache = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:2791:  ctx = PyCObject_AsVoidPtr(cobj);
./python-krbV-1.0.90/krb5module.c:2801:      cc = PyCObject_AsVoidPtr(new_cc);
./python-krbV-1.0.90/krb5module.c:2822:      cobj = PyCObject_FromVoidPtrAndDesc(cc, ctx, is_dfl?NULL:destroy_ccache);
./python-krbV-1.0.90/krb5module.c:2831:	  princ = PyCObject_AsVoidPtr(ppo);
./python-krbV-1.0.90/krb5module.c:2873:	ctx = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:2876:  princ = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:2878:  otherprinc = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:2922:	ctx = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:2926:    ccache = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:2935:    otmp = PyCObject_FromVoidPtrAndDesc(princ, ctx, destroy_principal);
./python-krbV-1.0.90/krb5module.c:2993:	ctx = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:2997:    ccache = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:3000:    kt = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:3011:    princ = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:3067:	ctx = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:3071:    ccache = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:3081:    princ = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:3210:  in_creds.client = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:3213:  in_creds.server = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:3219:  ctx = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:3222:  ccache = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:3234:      subargs = Py_BuildValue("(O)", PyCObject_FromVoidPtrAndDesc(princ, ctx, destroy_principal));
./python-krbV-1.0.90/krb5module.c:3248:      subargs = Py_BuildValue("(O)", PyCObject_FromVoidPtrAndDesc(princ, ctx, destroy_principal));
./python-krbV-1.0.90/krb5module.c:3368:	    ctx = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:3372:	rcache = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:3431:  ctx = PyCObject_AsVoidPtr(cobj);
./python-krbV-1.0.90/krb5module.c:3453:      cobj = PyCObject_FromVoidPtr(rcache, NULL);
./python-krbV-1.0.90/krb5module.c:3495:	ctx = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:3498:  princ = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:3500:  otherprinc = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:3581:	    ctx = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:3585:	keytab = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:3643:	    ctx = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:3647:	keytab = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:3721:  ctx = PyCObject_AsVoidPtr(cobj);
./python-krbV-1.0.90/krb5module.c:3726:      keytab = PyCObject_AsVoidPtr(new_kt);
./python-krbV-1.0.90/krb5module.c:3745:      cobj = PyCObject_FromVoidPtrAndDesc(keytab, ctx, destroy_keytab);
./python-krbV-1.0.90/krb5module.c:3787:	ctx = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:3790:  princ = PyCObject_AsVoidPtr(tmp);
./python-krbV-1.0.90/krb5module.c:3792:  otherprinc = PyCObject_AsVoidPtr(tmp);
Comment 1 Dave Malcolm 2010-08-20 00:09:58 UTC 
Created attachment 439826 [details]
Initial attempt at a patch for this (doesn't yet compile)

I had a go at generalizing the PyCObject usage so that it works with either PyCObject or PyCapsule; with the latter, every pointer lookup is type-checked; this could lead to a NULL return (and exception ) if the wrong types are used.

Doesn't yet compile.

Mike: does this approach look reasonable?
Comment 2 Fedora End Of Life 2012-08-16 19:29:12 UTC 
This message is a notice that Fedora 14 is now at end of life. Fedora 
has stopped maintaining and issuing updates for Fedora 14. It is 
Fedora's policy to close all bug reports from releases that are no 
longer maintained.  At this time, all open bugs with a Fedora 'version'
of '14' have been closed as WONTFIX.

(Please note: Our normal process is to give advanced warning of this 
occurring, but we forgot to do that. A thousand apologies.)

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, feel free to reopen 
this bug and simply change the 'version' to a later Fedora version.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we were unable to fix it before Fedora 14 reached end of life. If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora, you are encouraged to click on 
"Clone This Bug" (top right of this page) and open it against that 
version of Fedora.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping