Bug 624465 (perl-Lingua-Stem)

Taking.

 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
 [x] Package meets the Packaging Guidelines including the Perl specific items
 [x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
     Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=2417096

 [x] Rpmlint output: 
perl-Snowball-Swedish.noarch: W: no-manual-page-for-binary stemmer-se
perl-Snowball-Swedish.src: W: no-cleaning-of-buildroot %install
perl-Snowball-Swedish.src: W: no-cleaning-of-buildroot %clean
perl-Snowball-Swedish.src: W: no-buildroot-tag
perl-Snowball-Swedish.src: W: no-%clean-section
perl-Snowball-Swedish.src: W: invalid-url Source0: http://www.cpan.org/authors/id/A/AS/ASKSH/Snowball-Swedish-1.2.tar.gz <urlopen error timed out>
perl-Snowball-Swedish.spec: W: no-cleaning-of-buildroot %install
perl-Snowball-Swedish.spec: W: no-cleaning-of-buildroot %clean
perl-Snowball-Swedish.spec: W: no-buildroot-tag
perl-Snowball-Swedish.spec: W: no-%clean-section
perl-Snowball-Swedish.spec: W: invalid-url Source0: http://www.cpan.org/authors/id/A/AS/ASKSH/Snowball-Swedish-1.2.tar.gz <urlopen error timed out>
2 packages and 1 specfiles checked; 0 errors, 11 warnings.

 [x] Package is not relocatable.
 [x] Buildroot is correct
No buildroot defined, default is used

 [x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
 [x] License field in the package spec file matches the actual license.
     License type: GPL+ or Artistic

This one has the same problem as #624461. Header says GPLv2 only, pod says Perl.

 [x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
 [x] Spec file is legible and written in American English.
 [x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
e2ed0f5c2a9fc7e500c61553c4c1e9c9  Snowball-Swedish-1.2.tar.gz

 [x] Package is not known to require ExcludeArch
 [x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [x] Package must own all directories that it creates.
 [x] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [-] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -devel subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [x] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
 [x] Package does not own files or directories owned by other packages.

=== SUGGESTED ITEMS ===
 [x] Latest version is packaged.
 [x] Package does not include license text files separate from upstream.
 [-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
     Tested on: rawhide.x86_64
 [x] Package should compile and build into binary rpms on all supported
architectures.
     Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=2417096

 [!] Package has a %clean section, which contains rm -fR $RPM_BUILD_ROOT.
 [?] Package functions as described.
 [-] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files is correct.
 [-] File based requires are sane.
 [x] %check is present and the tests pass
All tests successful.
Files=3, Tests=30626, 10 wallclock secs ( 3.72 usr  0.23 sys +  9.10 cusr  0.21 csys = 13.26 CPU)
Result: PASS

APPROVED.

New Package CVS Request
=======================
Package Name: perl-Lingua-Stem
Short Description: Stemming of words
Owners: iarnell
Branches: F-13 F-14
InitialCC: perl-sig

Wait a minute. I think you've reviewed the wrong package - it looks like you've done perl-Snowball-Swedish twice.

Yeah, I pasted my review in the wrong tab. I'll do this one once its dependencies hit rawhide.

I'll remove the review flag then.

Taking again.

 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
 [x] Package meets the Packaging Guidelines including the Perl specific items
 [x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
     Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=2436120

 [x] Rpmlint output:
perl-Lingua-Stem.spec: W: no-cleaning-of-buildroot %install
perl-Lingua-Stem.spec: W: no-cleaning-of-buildroot %clean
perl-Lingua-Stem.spec: W: no-buildroot-tag
perl-Lingua-Stem.spec: W: no-%clean-section
perl-Lingua-Stem.src: W: no-cleaning-of-buildroot %install
perl-Lingua-Stem.src: W: no-cleaning-of-buildroot %clean
perl-Lingua-Stem.src: W: no-buildroot-tag
perl-Lingua-Stem.src: W: no-%clean-section
2 packages and 1 specfiles checked; 0 errors, 8 warnings.

 [x] Package is not relocatable.
 [x] Buildroot is correct
No buildroot defined, default used

 [x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
 [x] License field in the package spec file matches the actual license.
     License type: GPL+ or Artistic
 [x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
 [x] Spec file is legible and written in American English.
 [x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
a236b5d85ac49f84aad447c1383ad2de  Lingua-Stem-0.84.tar.gz

 [x] Package is not known to require ExcludeArch
 [x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [x] Package must own all directories that it creates.
 [x] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [-] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -devel subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [x] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI
application.
 [x] Package does not own files or directories owned by other packages.

=== SUGGESTED ITEMS ===
 [x] Latest version is packaged.
 [x] Package does not include license text files separate from upstream.
 [-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
     Tested on: rawhide.x86_64
 [x] Package should compile and build into binary rpms on all supported
architectures.
     Tested on: http://koji.fedoraproject.org/koji/taskinfo?taskID=2436120
 [!] Package has a %clean section, which contains rm -fR $RPM_BUILD_ROOT.
 [?] Package functions as described.
 [-] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files is correct.
 [-] File based requires are sane.
 [x] %check is present and the tests pass
All tests successful.
Files=5, Tests=25,  1 wallclock secs ( 0.03 usr  0.01 sys +  0.40 cusr  0.04 csys =  0.48 CPU)
Result: PASS

APPROVED.

New Package CVS Request
=======================
Package Name: perl-Lingua-Stem
Short Description: Stemming of words
Owners: iarnell
Branches: F-13 F-14
InitialCC: perl-sig

Git done (by process-git-requests).

Imported and built for rawhide - just waiting on the last couple of deps to go stable on branches.

Thanks for yet another review.

perl-Lingua-Stem-0.84-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/perl-Lingua-Stem-0.84-1.fc14

perl-Lingua-Stem-0.84-1.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/perl-Lingua-Stem-0.84-1.fc13

perl-Lingua-Stem-0.84-1.fc13 has been pushed to the Fedora 13 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update perl-Lingua-Stem'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/perl-Lingua-Stem-0.84-1.fc13

perl-Lingua-Stem-0.84-1.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

perl-Lingua-Stem-0.84-1.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.