Bug 624485
Summary: | setup dsktune check step should default to "yes" if no problems found | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Retired] 389 | Reporter: | Gerhardus Geldenhuis <gerhardus.geldenhuis> | ||||||
Component: | Install/Uninstall | Assignee: | Rich Megginson <rmeggins> | ||||||
Status: | CLOSED CURRENTRELEASE | QA Contact: | Viktor Ashirov <vashirov> | ||||||
Severity: | low | Docs Contact: | |||||||
Priority: | low | ||||||||
Version: | 1.2.6 | CC: | amsharma, jgalipea, nhosoi, rmeggins | ||||||
Target Milestone: | --- | ||||||||
Target Release: | --- | ||||||||
Hardware: | All | ||||||||
OS: | Linux | ||||||||
Whiteboard: | |||||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | 2015-12-07 16:39:50 UTC | Type: | --- | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Bug Depends On: | |||||||||
Bug Blocks: | 639035, 656390 | ||||||||
Attachments: |
|
Description
Gerhardus Geldenhuis
2010-08-16 15:35:30 UTC
What about if there are warnings? e.g. WARNING: There are only 1024 file descriptors (hard limit) available, which limit the number of simultaneous connections. WARNING: There are only 1024 file descriptors (soft limit) available, which limit the number of simultaneous connections. In this case, should the default response be [no] or [yes]? Created attachment 474704 [details]
0001-Bug-624485-setup-dsktune-check-step-should-default-t.patch
Note: currently, dsktune will only exit with 1 if errors are found. If only warnings and notices are found, it will exit with 0.
To ssh://git.fedorahosted.org/git/389/ds.git 466f679..f2a1d62 master -> master commit f2a1d62458458ca9bbceb436642a6cbf2e30c322 Author: Rich Megginson <rmeggins> Date: Fri Jan 21 14:50:04 2011 -0700 Reviewed by: nhosoi (Thanks!) Branch: master Fix Description: Check the result of the output of running dsktune - if success, set the default answer to yes, otherwise, to no. Platforms tested: RHEL6 x86_64 Flag Day: no Doc impact: no It should defintely stop at warnings but not info. Not enough file descriptors is a good enough reason to set the default option to no in my opinion as it can cause support issues later on when someone did not set them or forgot to do so. Created attachment 474979 [details]
0001-Bug-624485-setup-dsktune-check-step-should-default-t.patch
To ssh://git.fedorahosted.org/git/389/ds.git 07d9cb2..9f1160c master -> master commit 9f1160ce0732809b540a98549e21b9e64bcbae04 Author: Rich Megginson <rmeggins> Date: Mon Jan 24 09:12:22 2011 -0700 Reviewed by: nhosoi (Thanks!) Branch: master Fix Description: Additional change - if warnings are reported, exit 1 instea of 0, and print a message telling the user to review the warnings printed by the program. This will have the effect of making setup default to No if warnings are reported. Platforms tested: RHEL6 x86_64 Flag Day: no Doc impact: no Steps to verify Run setup-ds.pl ============================================================================== Your system has been scanned for potential problems, missing patches, etc. The following output is a report of the items found that need to be addressed before running this software in a production environment. 389 Directory Server system tuning analysis version 10-AUGUST-2007. If no errors nor warnings are detected, the default value would be [yes]: Would you like to continue? [yes]: If some error or warnings are detected, e.g., WARNING: There are only 1024 file descriptors (soft limit) available, which limit the number of simultaneous connections. this WARNING message is printed and the default prompt would be [no]: WARNING : The warning messages above should be reviewed before proceeding. Would you like to continue? [no]: [root@amsharma tmp]# setup-ds.pl ============================================================================== Default is yes here. ========================== This program will set up the 389 Directory Server. It is recommended that you have "root" privilege to set up the software. Tips for using this program: - Press "Enter" to choose the default and go to the next screen - Type "Control-B" or the word "back" then "Enter" to go back to the previous screen - Type "Control-C" to cancel the setup program Would you like to continue with set up? [yes]: ===================== Default is no here. ====================== Your system has been scanned for potential problems, missing patches, etc. The following output is a report of the items found that need to be addressed before running this software in a production environment. 389 Directory Server system tuning analysis version 10-AUGUST-2007. NOTICE : System is x86_64-unknown-linux2.6.32-131.6.1.el6.x86_64 (1 processor). NOTICE : The net.ipv4.tcp_keepalive_time is set to 7200000 milliseconds (120 minutes). This may cause temporary server congestion from lost client connections. WARNING: There are only 1024 file descriptors (hard limit) available, which limit the number of simultaneous connections. WARNING: There are only 1024 file descriptors (soft limit) available, which limit the number of simultaneous connections. WARNING : The warning messages above should be reviewed before proceeding. Would you like to continue? [no]: Exiting . . . Log file is '/tmp/setupCZ5NlK.log' Hence VERIFIED. |