Bug 624580
Summary: | reposync core dumps on large downloads (likely: pycurl, Py_None DECREF issue) | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | James Antill <james.antill> |
Component: | python-pycurl | Assignee: | Jeffrey C. Ollie <jeff> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | low | ||
Version: | 13 | CC: | daniel, dmalcolm, jeff, kklic, smooge |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | python-pycurl-7.19.0-7.fc13 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | 624559 | Environment: | |
Last Closed: | 2010-09-11 03:38:51 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
James Antill
2010-08-17 05:02:43 UTC
This really should be fixed before people start doing F-13 => F-14 yum updates. I assume dito. for the anaconda install (I'm shocked people haven't hit it there already, testing F-14). We're getting some weird FTP-related behavior with unexplained socket timeouts but I haven't heard of anything else going on that could be attributed to pycurl. I thought about it more overnight, and I guessed that it's possible when running in anaconda there are a enough more Py_None values used so the reference count is high enough that it's hard to trigger it. I checked upstream CVS and found that this patch was added a few months ago: http://pycurl.cvs.sourceforge.net/viewvc/pycurl/pycurl/src/pycurl.c?r1=1.148&r2=1.149 Does this look like a reasonable fix? If so I'll get new packages built ASAP. Of course PyCURL looks like an almost dead project upstream... (In reply to comment #4) > I checked upstream CVS and found that this patch was added a few months ago: > > http://pycurl.cvs.sourceforge.net/viewvc/pycurl/pycurl/src/pycurl.c?r1=1.148&r2=1.149 Sorry for the duplicated work; I've been looking at this from the RHEL side; see: https://bugzilla.redhat.com/show_bug.cgi?id=624559#c8 You may want to add yourself to the CC on that bug. > Does this look like a reasonable fix? If so I'll get new packages built ASAP. Yes. (In the RHEL bug I'm advocating an absolutely minimal one-liner fix out of paranoia; Fedora probably should simply use the upstream fix) > Of course PyCURL looks like an almost dead project upstream... Yeh, the part inside the reset function looks safe ... but the minimal one liner is probably best for RHEL-6.0 :) The very last change in the upstream patch looks weird though (adding a res global), I'm wondering if that's a copy and paste error. Jeff, You're wrong about pycurl being ALMOST dead. I'm reasonably certain it is actually dead. The last guy who was doing any kind of maintenance work on it works on opensolaris pkg manager and I suspect he's going to be busy for a while. (In reply to comment #6) > Yeh, the part inside the reset function looks safe ... but the minimal one > liner is probably best for RHEL-6.0 :) > > The very last change in the upstream patch looks weird though (adding a res > global), I'm wondering if that's a copy and paste error. Well I'll stick with the minimal patch that RHEL uses. I'm a believer in KISS and I don't have a lot of time to investigate any problems that might be added by the patch. I'll have new packages building soon. python-pycurl-7.19.0-7.fc14 has been submitted as an update for Fedora 14. http://admin.fedoraproject.org/updates/python-pycurl-7.19.0-7.fc14 python-pycurl-7.19.0-7.fc13 has been submitted as an update for Fedora 13. http://admin.fedoraproject.org/updates/python-pycurl-7.19.0-7.fc13 python-pycurl-7.19.0-7.fc12 has been submitted as an update for Fedora 12. http://admin.fedoraproject.org/updates/python-pycurl-7.19.0-7.fc12 I'm convinced the pycurl guys will all appreciate your help. It is still widely used, only undermanned. python-pycurl-7.19.0-7.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update python-pycurl'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/python-pycurl-7.19.0-7.fc14 python-pycurl-7.19.0-7.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. python-pycurl-7.19.0-7.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. python-pycurl-7.19.0-7.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. |