Bug 624862

Summary:	[rhel5.6] XFS incorrectly validates inodes
Product:	Red Hat Enterprise Linux 5	Reporter:	Dave Chinner <dchinner>
Component:	kernel	Assignee:	Dave Chinner <dchinner>
Status:	CLOSED ERRATA	QA Contact:	Petr Beňas <pbenas>
Severity:	urgent	Docs Contact:
Priority:	high
Version:	5.6	CC:	dhoward, esandeen, eteo, jarod, jpirko, kzhang, lwang, pbenas, plyons, pstehlik
Target Milestone:	rc	Keywords:	ZStream
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	624860	Environment:
Last Closed:	2011-01-13 21:10:12 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	624860, 626489, 633178
Bug Blocks:	629219

Description Dave Chinner 2010-08-18 00:22:40 UTC

+++ This bug was initially created as a clone of Bug #624860 +++

Description of problem:

The recent security fix in bz #607031 to validate untrusted inode numbers has caused a regression. This was found upstream, the result of it is that xfsdump breaks (results in incomplete backups) and will also affect NFS servers by returning ESTALE to valid handles. Description and patch that fixes the problem posted on the XFs community list here:

http://oss.sgi.com/archives/xfs/2010-08/msg00179.html

Version-Release number of selected component (if applicable):

RHEL 6.0

(Note also affects rhel5.6, will clone this bug for 5.6 fix)

How reproducible:

100%

Steps to Reproduce:

$ sudo sh -c "echo 3 > /proc/sys/vm/drop_caches"
$ sudo xfsdump -l0 -L "Test" - /dev/vda 2> t.t |gzip - > ~/dump_test.gz

Will result in an incomplete backup every time.

Comment 2 Eugene Teo (Security Response) 2010-08-24 00:28:39 UTC

*** Bug 626489 has been marked as a duplicate of this bug. ***

Comment 3 RHEL Program Management 2010-08-27 19:09:23 UTC

This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
release.

Comment 9 Jarod Wilson 2010-09-03 19:06:56 UTC

in kernel-2.6.18-215.el5
You can download this test kernel from http://people.redhat.com/jwilson/el5

Detailed testing feedback is always welcomed.

Comment 11 Petr Beňas 2010-10-20 11:41:14 UTC

reproduced in 2.6.18-214.el5 and verified in 2.6.18-215.el5.

Comment 14 errata-xmlrpc 2011-01-13 21:10:12 UTC

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2011-0017.html