Bug 624865
| Summary: | Review Request: minion - Fast, Scalable Constraint Solving | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Lameire Alexis <alexis.lameire> |
| Component: | Package Review | Assignee: | Mamoru TASAKA <mtasaka> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | athmanem, fedora-package-review, mtasaka, notting, pikachu.2014, susi.lehtola, tcallawa |
| Target Milestone: | --- | Flags: | mtasaka:
fedora-review+
kevin: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | minion-0.10-4.fc14 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-08-30 16:57:55 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Lameire Alexis
2010-08-18 00:25:25 UTC
IMHO, the examples should be moved to "doc", this will helps to get ride of warnings also it seems that the links are down. examples needs to own
%{_datadir}/%{name}/
as it's not owned by any other package.
However, I don't see the point of using %{_datadir} for the examples - IMHO they should go in %{_docdir}.
Thanks for all your comments, here is a new version based on them: SPEC url: http://pikachu.2014.free.fr/public/alexises/packaging/minion/0.10-2/minion.spec SRPM url: http://pikachu.2014.free.fr/public/alexises/packaging/minion/0.10-2/minion-0.10-2.fc13.src.rpm I finally suppressed the -doc subpackage since it contained only one PDF file. I also fixed some rpmlint issues appeared after moving the example files in %{_docdir}. rpmlint outputs (real false positives this time): minion.src: W: spelling-error %description -l en_US toolkits -> toolkit, tool kits, tool-kits minion.x86_64: W: spelling-error %description -l en_US toolkits -> toolkit, tool kits, tool-kits minion.x86_64: W: no-manual-page-for-binary minion 4 packages and 0 specfiles checked; 0 errors, 3 warnings. Well, - It seems that files under nauty24b7/ directory is licensed under the license shown in ./nauty24b7/nauty-h.in : -------------------------------------------------------------------- * Copyright (1984-2007) Brendan McKay. All rights reserved. Permission * * is hereby given for use and/or distribution with the exception of * * sale for profit or application with nontrivial military significance. * * You must not remove this copyright notice, and you must document any * * changes that you make to this program. * * This software is subject to this copyright only, irrespective of * * any copyright attached to any package of which this is a part. * * * * This program is only provided "as is". No responsibility will be taken * * by the author, his employer or his pet rabbit* for any misfortune which * * befalls you because of its use. I don't think it will delete all your * * files, burn down your computer room or turn your children against you, * * but if it does: stiff cheddar. On the other hand, I very much welcome * * bug reports, or at least I would if there were any bugs. * * * RIP, 1989 * -------------------------------------------------------------------- , which is also shown on http://cs.anu.edu.au/~bdm/nauty/ I think "with the exception of sale for profit" part is clearly non-free. Once blocking FE-Legal. (Removing NEEDSPONSOR) Yep. Mamoru is right, that license is non-free. Any chance that Brendan McKay is willing or able to relicense? I have just sent a mail to the minion developers, and they answered quite quickly, as usual: https://mail.cs.st-andrews.ac.uk/pipermail/mug/2010-August/000065.html So I can safely disable the use of nauty since it is not used actually. In this case, should I clean the sources by removing nauty when making my SRPM? You'll need to clean the sources, because the license restricts distribution. Thanks Tom for your advice. I have corrected the problem with nauty: here is the new release: SPEC : http://alexises.fedorapeople.org/minion/0.10-3/minion.spec SRCRPM : http://alexises.fedorapeople.org/minion/0.10-3/minion-0.10-3.fc13.src.rpm Koji build : http://koji.fedoraproject.org/koji/taskinfo?taskID=2421912 In this release : * Clean script to remove the nauty library code * New tarball generated by the clean script * disabled the nauty build option. If it OK like this, I will remove the FE-legal blocker. Looks fine. Lifting FE-Legal. Thanks Lameire. Okay.
- Please change the permission of "minion-generate-tarball.sh" in
srpm to 0644.
-----------------------------------------------------------
This package (minion) is APPROVED by mtasaka
-----------------------------------------------------------
and thans to all people for pre-reviewing this package.
New Package SCM Request ======================= Package Name: minion Short Description: Fast, Scalable Constraint Solving Owners: alexises Branches: f13 f14 InitialCC: Git done (by process-git-requests). minion-0.10-4.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/minion-0.10-4.fc14 minion-0.10-4.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/minion-0.10-4.fc13 Closing. minion-0.10-4.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. minion-0.10-4.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. |