Bug 624878

Summary: dhcpv6: fix the typo when parsing REBINDTIME option
Product: [Fedora] Fedora Reporter: ShanWei <shanwei>
Component: dhcpv6Assignee: Orphan Owner <extras-orphan>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: 12CC: extras-orphan, shanwei
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-09-03 07:48:53 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description ShanWei 2010-08-18 01:24:06 UTC
When I used dhcp6c, I found the the error:
Aug/17/2010 23:07:13 /tmp/dhcp6c.conf:6 duplicated rebindtime for eth1
Aug/17/2010 23:07:13 failed to parse configuration file
 
Steps to Reproduce:
1. create config file
[root@(none) ~]# cat /tmp/dhcp6c.conf
interface eth1
{
 iaid 111111;
 request domain-name-servers;
 request domain-search-list;
 renew-time 50;
 rebind-time 80;
};

2.#dhcp6c -f -v -c /tmp/dhcp6c.conf eth1
(version:dhcpv6-client-1.2.0-4.fc12.x86_64)

With the meaning of the message, dhcp6c should check ifc->iaidinfo.rebindtime not ifc->iaidinfo.iaid.

P.S. I have compiled dhcpv6 source and met the error of "No package 'libnl-1' found". So this patch is not test.


Signed-off-by: Shan Wei <shanwei.com>
---
 src/confdata.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/src/confdata.c b/src/confdata.c
index 285f017..64ad83c 100644
--- a/src/confdata.c
+++ b/src/confdata.c
@@ -212,7 +212,7 @@ int configure_interface(const struct cf_namelist *iflist) {
 
                     break;
                 case DECL_REBINDTIME:
-                    if (ifc->iaidinfo.iaid) {
+                    if (ifc->iaidinfo.rebindtime) {
                         dhcpv6_dprintf(LOG_ERR, "%s" "%s:%d "
                                        "duplicated rebindtime for %s",
                                        FNAME, configfilename,

Comment 1 ShanWei 2010-09-03 07:48:53 UTC
dhcpv6 (and dhcpv6-client) has been obsoleted. And there is no problem in dhclient packet. So close this one.