Bug 62489

Summary:	warning and error if --rsh=prog is specified for rsync:// transfer
Product:	[Retired] Red Hat Public Beta	Reporter:	Alexandre Oliva <aoliva>
Component:	rsync	Assignee:	Bill Nottingham <notting>
Status:	CLOSED RAWHIDE	QA Contact:	Aaron Brown <abrown>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	skipjack-beta1	CC:	rvokal
Target Milestone:	---
Target Release:	---
Hardware:	i386
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2002-04-01 21:22:38 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	61901

Description Alexandre Oliva 2002-04-01 18:28:51 UTC

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.9) Gecko/20020314

Description of problem:
Transfers using the rsync:// protocol disregard the --rsh=prog option, and they
warn so.  However, this option also causes a hard error at the end of the transfer.

Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
1./usr/bin/rsync -r rsync://distro.ibiblio.org/redhat/rawhide/RedHat/ RedHat/  #
will transfer only an empty directory, no worries
2./usr/bin/rsync -e ssh -r rsync://distro.ibiblio.org/redhat/rawhide/RedHat/
RedHat/ # error
3./usr/bin/rsync --rsh ssh -r rsync://distro.ibiblio.org/redhat/rawhide/RedHat/
RedHat/ # error

Actual Results:  1.Successful transfer of an empty RPMS directory.  Exit status
is 0.
2 and 3:
WARNING: --rsh or -e option ignored when connecting to rsync daemon
[...]
rsync error: partial transfer (code 23) at main.c(893)

Exit status is non-zero.  Oops.

Expected Results:  The warning is appropriate, indeed, but the hard error is not.

Additional info:

Comment 1 Bill Nottingham 2002-04-11 03:52:23 UTC

Fixed in 2.5.4-2 - thanks!

Comment 2 Martin Pool 2002-04-15 07:51:33 UTC

Bill, I have your patch, it will be merged in upstream 2.5.6.