Bug 624919

+++ This bug was initially created as a clone of Bug #623788 +++

Description of problem:

The init script is broken for restarts.  I think this fixes:

diff -u -r1.1 autofs-5.0.5-make-redhat-init-script-more-lsb-compliant.patch
--- autofs-5.0.5-make-redhat-init-script-more-lsb-compliant.patch       24 May
2010 03:01:04 -0000       1.1
+++ autofs-5.0.5-make-redhat-init-script-more-lsb-compliant.patch       19 Jul
2010 17:47:14 -0000
@@ -61,7 +61,7 @@

  function restart() {
 -      stop
-+      status > /dev/null 2>&1
++      status -p /var/run/autofs.pid -l autofs $prog > /dev/null 2>&1
 +      if [ $? -eq 0 ]; then
 +              stop
 +      fi

--- Additional comment from michal on 2010-08-12 18:38:42 EDT ---

(In reply to comment #0)

> The init script is broken for restarts.  I think this fixes:

It appears that this should read:

   status -p /var/run/autofs.pid -l $prog

instead of 

   status -p /var/run/autofs.pid -l autofs $prog

but this indeed fixes the problem for me.  autofs-5.0.5-26.fc13 has surely broken startup script as 'status > /dev/null 2>&1' invariably ends as 1.

--- Additional comment from orion.com on 2010-08-12 18:46:29 EDT ---

I think my original is correct. -p is pid file, -l is lock file name, and then you pass the program name.

--- Additional comment from michal on 2010-08-12 19:04:06 EDT ---

(In reply to comment #2)
> I think my original is correct. -p is pid file, -l is lock file name, and then
> you pass the program name.    

Yes, I think that you are right. OTOH it appears that just
'status -p /var/run/autofs.pid' is good enough and remaining arguments are not that essential.

--- Additional comment from ikent on 2010-08-18 01:01:58 EDT ---

(In reply to comment #3)
> (In reply to comment #2)
> > I think my original is correct. -p is pid file, -l is lock file name, and then
> > you pass the program name.    
> 
> Yes, I think that you are right. OTOH it appears that just
> 'status -p /var/run/autofs.pid' is good enough and remaining arguments are not
> that essential.

It turns out that changing the status call to "status autofs"
will use the correct pid file.

--- Additional comment from ikent on 2010-08-18 01:02:33 EDT ---



--- Additional comment from updates on 2010-08-18 01:06:03 EDT ---

autofs-5.0.5-27.fc13 has been submitted as an update for Fedora 13.
http://admin.fedoraproject.org/updates/autofs-5.0.5-27.fc13