Bug 625078
Summary: | [NFS]: silly renamed .nfs0000* files can be left on fs forever | ||||||
---|---|---|---|---|---|---|---|
Product: | Red Hat Enterprise Linux 6 | Reporter: | Fabio Olive Leite <fleite> | ||||
Component: | kernel | Assignee: | Jeff Layton <jlayton> | ||||
Status: | CLOSED DUPLICATE | QA Contact: | Red Hat Kernel QE team <kernel-qe> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | 6.0 | CC: | aveseb, bfields, fleite, jlayton, khorenko, rwheeler, steved, tao, trond.myklebust | ||||
Target Milestone: | rc | ||||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | 511901 | Environment: | |||||
Last Closed: | 2010-11-15 14:03:49 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | 511901 | ||||||
Bug Blocks: | |||||||
Attachments: |
|
Description
Fabio Olive Leite
2010-08-18 14:34:43 UTC
I own the RHEL-5 one, so I'll grab the RHEL6 one as well. We'll definitely want to fix this in RHEL6, but a fix will need to go upstream first. I sent a note about this problem to the upstream ML along with what I think is the best way to fix it: http://www.spinics.net/lists/linux-nfs/msg15082.html I'll look at this as soon as I have some time to spend on it. Created attachment 446520 [details]
patch -- make sillyrename an async operation
This patchset seems to fix the problem for me. The basic approach is to make sillyrename an asynchronous operation. The caller just waits for the task to complete. If a task is interrupted via SIGKILL, the sillyrename operation will still continue in the background.
This still needs more testing and I need to clean up the commitlog contents, but I'll probably post this upstream within the next week or so. Any testing feedback would be appreciated...
Ran reproducer in a loop over several hours and ended up with 0 leftover .nfs* files. Seems to work as expected. I'll clean up the set a bit and plan to send it upstream soon. Trond is planning to push the patchset for 2.6.37. If all goes well, we should be able to make 6.1 with this. This request was evaluated by Red Hat Product Management for inclusion in a Red Hat Enterprise Linux maintenance release. Product Management has requested further review of this request by Red Hat Engineering, for potential inclusion in a Red Hat Enterprise Linux Update release for currently deployed products. This request is not yet committed for inclusion in an Update release. |