Bug 625947
Summary: | openais should handle non null terminated chkpoint strings | ||||||
---|---|---|---|---|---|---|---|
Product: | Red Hat Enterprise Linux 5 | Reporter: | Steven Dake <sdake> | ||||
Component: | openais | Assignee: | Steven Dake <sdake> | ||||
Status: | CLOSED ERRATA | QA Contact: | Cluster QE <mspqa-list> | ||||
Severity: | high | Docs Contact: | |||||
Priority: | high | ||||||
Version: | 5.5 | CC: | agk, cluster-maint, cmarthal, edamato, fdinitto, jkortus, lhh, sdake | ||||
Target Milestone: | rc | Keywords: | ZStream | ||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | openais-0.80.6-28.el5 | Doc Type: | Bug Fix | ||||
Doc Text: |
When a checkpoint name was not terminated with the NULL character, the aisexec process may have terminated unexpectedly with a segmentation fault, causing a cluster outage. With this update, the underlying source code has been modified to resolve this issue, and such strings no longer cause aisexec to crash.
|
Story Points: | --- | ||||
Clone Of: | 625601 | Environment: | |||||
Last Closed: | 2011-01-13 23:57:41 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | 625601 | ||||||
Bug Blocks: | 638608, 638609 | ||||||
Attachments: |
|
Description
Steven Dake
2010-08-20 21:30:46 UTC
Steve, since this hasn't been hit in RHEL5 can you provide a reproducer and test results? When I finish the patch I am planning to test with saftest (~100 ckpt test cases). Don't have any idea how to reproduce, however code in rhel5 is nearly identical to code in rhel6 for this service. tested with debug: on to ensure all the printing statements were triggered saftest ckpt test cases run on openais-0.80.6-16.el5 (rhel5.5 base release) [root@mrg-02 AIS-ckpt-B.01.01]# ./run_tests.sh all ./run_tests.sh: line 32: 17861 Alarm clock $TIMEOUT_EXE 0 > /dev/null 2>&1 ./report.sh all [root@mrg-02 AIS-ckpt-B.01.01]# ./report.sh all [root@mrg-02 AIS-ckpt-B.01.01]# more result.txt Total run test cases: 403 Pass: 394 Fail: 7 Block: 0 Notsupport: 0 Noresolved: 2 Unknown reason: 0 Finish testing [root@mrg-02 AIS-ckpt-B.01.01]# ls find-test LDFLAGS Makefile result.txt src include log report.sh run_tests.sh saftest ckpt test cases run on scratch build including attached patch: (scratch build at https://brewweb.devel.redhat.com/taskinfo?taskID=2713013 [root@mrg-02 AIS-ckpt-B.01.01]# ./report.sh all [root@mrg-02 AIS-ckpt-B.01.01]# ls find-test LDFLAGS Makefile result.txt src include log report.sh run_tests.sh [root@mrg-02 AIS-ckpt-B.01.01]# more result.txt Total run test cases: 403 Pass: 395 Fail: 6 Block: 0 Notsupport: 0 Noresolved: 2 Unknown reason: 0 Finish testing [root@mrg-02 AIS-ckpt-B.01.01]# Patch does not appear to introduce regressions. Created attachment 441310 [details]
revision 2159 to fix problem
Steve, Does the newly passing test case cover the fix you're proposing here? There is no test case that is available to reproduce this issue - however the code is clearly defective. The ~400 test cases run in comment #4 provide high degree of confidence there is no regression as a result of the patch. Technical note added. If any revisions are required, please edit the "Technical Notes" field accordingly. All revisions will be proofread by the Engineering Content Services team. New Contents: When a checkpoint name was not terminated with the NULL character, the aisexec process may have terminated unexpectedly with a segmentation fault, causing a cluster outage. With this update, the underlying source code has been modified to resolve this issue, and such strings no longer cause aisexec to crash. An advisory has been issued which should help the problem described in this bug report. This report is therefore being closed with a resolution of ERRATA. For more information on therefore solution and/or where to find the updated files, please follow the link below. You may reopen this bug report if the solution does not work for you. http://rhn.redhat.com/errata/RHBA-2011-0100.html |