Bug 630052
| Summary: | gnome-session-save does not work from F9->F14 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dan Thurman <dant> | ||||||
| Component: | gnome-session | Assignee: | Ray Strode [halfline] <rstrode> | ||||||
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | low | ||||||||
| Version: | 14 | CC: | bernie+fedora, jmccann, rstrode | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | |||||||||
| : | 664516 (view as bug list) | Environment: | |||||||
| Last Closed: | 2012-08-16 20:12:55 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Dan Thurman
2010-09-03 15:35:14 UTC
Still does not work in F14. Is this a Fedora-specific bug or an upstream bug? Created attachment 469787 [details] Proposed patch for gnome-session I believe this is an upstream bug. What happens is that metacity uses the same state file each time, named after the SM client-id which remains. gnome-session removes 'old' the state file after the app has saved its state but metacity uses the same so its state file is removed by the session manager and the state is not restored (thus the position and workspace of running windows is not restored). The problem appears with that commit upstream: http://git.gnome.org/browse/gnome-session/commit/?id=3e346957cebcbf9e747757d2d649329266743afc The order of events is as follow (observed by enabling debug logs in both metacity and gnome-session): 1. Session terminating 2. Session manager sends a SaveYourself to all clients 3. metacity get SaveYouself messaage, save its state file and replies SaveYourselfDone 4. Session manager gets SaveYourselfDone 5. Session manager checks for discard_Exec in hash table in gnome-session/gsm-session-save.c gsm_session_clear_one_client() 6. Session manager does discard_exec in hash table so runs the discard_exec command thus removing the state-file in gnome-session/gsm-session-save.c gsm_session_clear_one_client() 7. Session manager adds the discard_exec to the hash table in save_one_client() So the discard command is never found in the has (as its' empty) because the hash is populated after the removal... gsm_session_save() | +-> gsm_session_clear_saved_session() | | | +-> gsm_session_clear_one_client() | | | +-> g_hash_table_lookup (discard_hash, discard_exec) ? | FALSE => g_spawn_async (discard_exec) | +-> save_one_client() | +-> g_hash_table_insert (data->discard_hash, discard_exec, discard_exec); The patch here attached does the things differently, it actually populates the discard_hash with the existing (old) discard commands, then save the session and removes the old discard command not found in the hash. With this patch, gnome-session and metacity behave as expected. Created attachment 469789 [details]
Build the discard_hash before saving/removing state files
Updated patch (remove an unrelated comment in the code)
This message is a notice that Fedora 14 is now at end of life. Fedora has stopped maintaining and issuing updates for Fedora 14. It is Fedora's policy to close all bug reports from releases that are no longer maintained. At this time, all open bugs with a Fedora 'version' of '14' have been closed as WONTFIX. (Please note: Our normal process is to give advanced warning of this occurring, but we forgot to do that. A thousand apologies.) Package Maintainer: If you wish for this bug to remain open because you plan to fix it in a currently maintained version, feel free to reopen this bug and simply change the 'version' to a later Fedora version. Bug Reporter: Thank you for reporting this issue and we are sorry that we were unable to fix it before Fedora 14 reached end of life. If you would still like to see this bug fixed and are able to reproduce it against a later version of Fedora, you are encouraged to click on "Clone This Bug" (top right of this page) and open it against that version of Fedora. Although we aim to fix as many bugs as possible during every release's lifetime, sometimes those efforts are overtaken by events. Often a more recent Fedora release includes newer upstream software that fixes bugs or makes them obsolete. The process we are following is described here: http://fedoraproject.org/wiki/BugZappers/HouseKeeping |