Bug 630058
| Summary: | Only match PPDs with compatible CMD fields | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Tim Waugh <twaugh> |
| Component: | system-config-printer | Assignee: | Tim Waugh <twaugh> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | jpopelka, till.kamppeter, twaugh |
| Target Milestone: | --- | Keywords: | FutureFeature |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | system-config-printer-1.2.5-6.fc13 | Doc Type: | Enhancement |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-11-22 22:14:15 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Tim Waugh
2010-09-03 15:44:53 UTC
For the upcoming Ubuntu Maverick release I have already fixed the problem but due to Ubuntu's Finale Freeze today I had not yet the time to put up the patches. I will provide them in the next days. Better suggestion from George Liu about the matching algorithm: If any word in the CMD field of the PPD's 1284DeviceID attribute appears in the printer MIB's CMD field, that PPD should be considered as matching the device. This allows several spellings of e.g. PostScript to be used in the PPD in order to match a variety of spellings from different versions of a printer product e.g. PS3, PS, POSTSCRIPT. Additionally, this allows for more than one type optional module in a device, e.g. PostScript and (say) CUPS-RASTER. As a special case, if no CMD field is present in the PPD's 1284DeviceID attribute, CMD field filtering will not be performed and so it will considered as a match for any device with matching MFG and MDL fields. Good idea, Tim. I have implemented it this way in Ubuntu Maverick now. Tim, I have sent you all patches by e-mail. Note that my changes only prioritize the PPDs and do not remove the unsuitable PPDs from the list. So automatic setups (via udev-configure-printer or if a matching PPD is found and the make/model step of the wizard skipped) will always select the CMD:-wise correct PPD and in the case that the make/model step is displayed, the correct PPD is moved to the top and marked (so that simply clicking Next, Next, Next, ... will do the right thing). Unsuitable PPDs (like PostScript PPD if no PostScript add-on is installed) will not suppressed from the list though. Therefore PPDs without device ID wth CMD: field will be considered non-matching. If there is no CMD:-prioritized PPD, only the old prioritization methods will get applied. I've fixed this upstream slightly differently. system-config-printer-1.2.5-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/system-config-printer-1.2.5-1.fc14 system-config-printer-1.2.5-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/system-config-printer-1.2.5-1.fc13 system-config-printer-1.2.5-1.fc13 has been pushed to the Fedora 13 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update system-config-printer'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/system-config-printer-1.2.5-1.fc13 system-config-printer-1.2.5-6.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. system-config-printer-1.2.5-6.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. |