Bug 630092
Description
Nathan Kinder
2010-09-03 17:14:44 UTC
Created attachment 447832 [details]
0001-Bug-630092-Coverity-12117-Resource-leaks-issues.patch
Created attachment 447833 [details]
0002-Bug-630092-Coverity-15478-Resource-leaks-issues.patch
Created attachment 447834 [details]
0003-Bug-630092-Coverity-15479-Resource-leaks-issues.patch
Created attachment 447835 [details]
0004-Bug-630092-Coverity-15481-Resource-leaks-issues.patch
Created attachment 447836 [details]
0005-Bug-630092-Coverity-15482-Resource-leaks-issues.patch
Created attachment 447837 [details]
0006-Bug-630092-Coverity-15483-Resource-leaks-issues.patch
Created attachment 447838 [details]
0007-Bug-630092-Coverity-15484-Resource-leaks-issues.patch
Created attachment 447840 [details]
0008-Bug-630092-Coverity-15485-Resource-leaks-issues.patch
Created attachment 447841 [details]
0009-Bug-630092-Coverity-15487-Resource-leaks-issues.patch
Created attachment 447842 [details]
0010-Bug-630092-Coverity-15490-Resource-leaks-issues.patch
Created attachment 447844 [details]
0011-Bug-630092-Coverity-15497-Resource-leaks-issues.patch
Comment on attachment 447836 [details]
0005-Bug-630092-Coverity-15482-Resource-leaks-issues.patch
The patch solves the problem. I just want to mention there's no need to introduce another flag free_local_subtree, but you can use "if (is_global)" to tell if local_subtree needs to be freed or not.
Comment on attachment 447838 [details]
0007-Bug-630092-Coverity-15484-Resource-leaks-issues.patch
There's no harm, bug I don't think this line is needed:
+ backentry_clear_entry(ep); /* entry is released in the frontend on failure*/
since if ep is NULL, backentry_clear_entry does nothing. If ep->ep_entry is NULL, you don't have to assign NULL again...
Created attachment 448050 [details]
0005b-Bug-630092-Coverity-15482-Resource-leaks-issues.patch
Created attachment 448051 [details]
0007b-Bug-630092-Coverity-15484-Resource-leaks-issues.patch
Pushed patches to master. Counting objects: 92, done. Delta compression using 2 threads. Compressing objects: 100% (77/77), done. Writing objects: 100% (77/77), 43.72 KiB, done. Total 77 (delta 61), reused 0 (delta 0) To ssh://git.fedorahosted.org/git/389/ds.git 8f1cdb3..2af08b3 master -> master Created attachment 448103 [details]
Patch for cov#12116
Created attachment 448107 [details]
Patch for cov#12105
Created attachment 448109 [details]
0001-Bug-630092-Coverity-11985-Resource-leaks-issues.patch
Created attachment 448110 [details]
0001-Bug-630092-Coverity-11991-Resource-leaks-issues.patch
Created attachment 448111 [details]
0001-Bug-630092-Coverity-12000-Resource-leaks-issues.patch
Created attachment 448112 [details]
0001-Bug-630092-Coverity-12003-Resource-leaks-issues.patch
Created attachment 448125 [details]
Patch for cov#12068
Created attachment 448128 [details]
Revised patch for cov#12105
Pushed additional patches to master. Counting objects: 63, done. Delta compression using 2 threads. Compressing objects: 100% (45/45), done. Writing objects: 100% (45/45), 4.52 KiB, done. Total 45 (delta 35), reused 0 (delta 0) To ssh://git.fedorahosted.org/git/389/ds.git 2af08b3..e84ef2e master -> master Created attachment 448133 [details]
0001-Bug-630092-Coverity-11992-11993-Resource-leaks-issue.patch
Pushed patch for cov#11992 and cov#11993 to master. Compressing objects: 100% (5/5), done. Writing objects: 100% (5/5), 630 bytes, done. Total 5 (delta 4), reused 0 (delta 0) To ssh://git.fedorahosted.org/git/389/ds.git e84ef2e..62cc84c master -> master *** Bug 603943 has been marked as a duplicate of this bug. *** Coverity Related, Can I request Dev to test this. |