Bug 630094
| Summary: | fix coverity Defect Type: Control flow issues | ||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Retired] 389 | Reporter: | Nathan Kinder <nkinder> | ||||||||||||||||||||||||||
| Component: | Directory Server | Assignee: | Nathan Kinder <nkinder> | ||||||||||||||||||||||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Chandrasekar Kannan <ckannan> | ||||||||||||||||||||||||||
| Severity: | medium | Docs Contact: | |||||||||||||||||||||||||||
| Priority: | high | ||||||||||||||||||||||||||||
| Version: | 1.2.6 | CC: | amsharma, benl, jgalipea | ||||||||||||||||||||||||||
| Target Milestone: | --- | ||||||||||||||||||||||||||||
| Target Release: | --- | ||||||||||||||||||||||||||||
| Hardware: | All | ||||||||||||||||||||||||||||
| OS: | Linux | ||||||||||||||||||||||||||||
| Whiteboard: | |||||||||||||||||||||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||||||||||||||||||||
| Doc Text: | Story Points: | --- | |||||||||||||||||||||||||||
| Clone Of: | Environment: | ||||||||||||||||||||||||||||
| Last Closed: | 2011-05-17 14:08:49 UTC | Type: | --- | ||||||||||||||||||||||||||
| Regression: | --- | Mount Type: | --- | ||||||||||||||||||||||||||
| Documentation: | --- | CRM: | |||||||||||||||||||||||||||
| Verified Versions: | Category: | --- | |||||||||||||||||||||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||||||||||||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||||||||||||||||||||
| Embargoed: | |||||||||||||||||||||||||||||
| Bug Depends On: | |||||||||||||||||||||||||||||
| Bug Blocks: | 639035 | ||||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||||
|
Description
Nathan Kinder
2010-09-03 17:17:44 UTC
Created attachment 446084 [details]
Patch for cov#11818
Created attachment 446087 [details]
Patch for cov#15451
Created attachment 446093 [details]
Patch for cov#15452
Created attachment 446094 [details]
Patch for cov#15453
Created attachment 446095 [details]
Patch for cov#15454
Created attachment 446098 [details]
Patch for cov#15455
Created attachment 446099 [details]
Patch for cov#15456
Created attachment 446101 [details]
Patch for cov#15457
Created attachment 446270 [details]
Patch for cov#15458
Created attachment 446273 [details]
Patch for cov#15459
Created attachment 446279 [details]
Patch for cov#15520
Comment on attachment 446098 [details]
Patch for cov#15455
Let me ask you to confirm one thing since it's a bit hard to see on the diff... The following checking still exists after "if ( argc > 1 )" clause, doesn't it? With the assumption, I put '+'. :)
196 if (!indexes) {
197 LDAPDebug(LDAP_DEBUG_ANY, "attr_index_config: Missing in dex\n", 0, 0, 0);
198 goto done;
199 }
200
(In reply to comment #13) > Comment on attachment 446098 [details] > Patch for cov#15455 > > Let me ask you to confirm one thing since it's a bit hard to see on the diff... > The following checking still exists after "if ( argc > 1 )" clause, doesn't > it? With the assumption, I put '+'. :) > > 196 if (!indexes) { > 197 LDAPDebug(LDAP_DEBUG_ANY, "attr_index_config: Missing > in dex\n", 0, 0, 0); > 198 goto done; > 199 } > 200 Yes, this check is still performed immediately after the "if (argc > 1)" block is finished. Pushed patches to master. Thanks to Noriko for her reviews! Counting objects: 93, done. Delta compression using 2 threads. Compressing objects: 100% (75/75), done. Writing objects: 100% (75/75), 9.79 KiB, done. Total 75 (delta 53), reused 0 (delta 0) To ssh://git.fedorahosted.org/git/389/ds.git 07d7c89..660629d master -> master Created attachment 446382 [details]
Patch for cov#15581
Comment on attachment 446382 [details]
Patch for cov#15581
Ah, I see... Sorry, I also missed them when I reviewed the previous fix...
Pushed additional patch to master. Thanks to Noriko for her review! Counting objects: 19, done. Delta compression using 2 threads. Compressing objects: 100% (11/11), done. Writing objects: 100% (11/11), 1.29 KiB, done. Total 11 (delta 8), reused 0 (delta 0) To ssh://git.fedorahosted.org/git/389/ds.git 660629d..b2799df master -> master Coverity Related, Can I request Dev to test this. |