Bug 630097
| Summary: | fix coverity Defect Type: Null pointer dereferences issues | ||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Retired] 389 | Reporter: | Nathan Kinder <nkinder> | ||||||||||||||||||||||||||||||||||||||||||||||||
| Component: | Directory Server | Assignee: | Nathan Kinder <nkinder> | ||||||||||||||||||||||||||||||||||||||||||||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Chandrasekar Kannan <ckannan> | ||||||||||||||||||||||||||||||||||||||||||||||||
| Severity: | medium | Docs Contact: | |||||||||||||||||||||||||||||||||||||||||||||||||
| Priority: | high | ||||||||||||||||||||||||||||||||||||||||||||||||||
| Version: | 1.2.6 | CC: | amsharma, benl, jgalipea | ||||||||||||||||||||||||||||||||||||||||||||||||
| Target Milestone: | --- | ||||||||||||||||||||||||||||||||||||||||||||||||||
| Target Release: | --- | ||||||||||||||||||||||||||||||||||||||||||||||||||
| Hardware: | All | ||||||||||||||||||||||||||||||||||||||||||||||||||
| OS: | Linux | ||||||||||||||||||||||||||||||||||||||||||||||||||
| Whiteboard: | |||||||||||||||||||||||||||||||||||||||||||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||||||||||||||||||||||||||||||||||||||||||
| Doc Text: | Story Points: | --- | |||||||||||||||||||||||||||||||||||||||||||||||||
| Clone Of: | Environment: | ||||||||||||||||||||||||||||||||||||||||||||||||||
| Last Closed: | 2011-05-17 14:08:46 UTC | Type: | --- | ||||||||||||||||||||||||||||||||||||||||||||||||
| Regression: | --- | Mount Type: | --- | ||||||||||||||||||||||||||||||||||||||||||||||||
| Documentation: | --- | CRM: | |||||||||||||||||||||||||||||||||||||||||||||||||
| Verified Versions: | Category: | --- | |||||||||||||||||||||||||||||||||||||||||||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||||||||||||||||||||||||||||||||||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||||||||||||||||||||||||||||||||||||||||||
| Embargoed: | |||||||||||||||||||||||||||||||||||||||||||||||||||
| Bug Depends On: | |||||||||||||||||||||||||||||||||||||||||||||||||||
| Bug Blocks: | 639035 | ||||||||||||||||||||||||||||||||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||||||||||||||||||||||||||||||||
|
Description
Nathan Kinder
2010-09-03 17:19:36 UTC
Created attachment 446995 [details]
Patch for cov#11933
Created attachment 447036 [details]
Patch for cov#11938
Created attachment 447038 [details]
Patch for cov#11946
Created attachment 447061 [details]
Revised patch for cov#11938
Created attachment 447062 [details]
Patch for cov#11964
Created attachment 447067 [details]
Patch for cov#12143
Created attachment 447250 [details]
Patch for cov#12148
Created attachment 447257 [details]
Patch for cov#12182
Created attachment 447259 [details]
Patch for cov#12182 & cov#12183
Created attachment 447279 [details]
Patch for cov#15460
Created attachment 447293 [details]
Patch for cov#15461
Created attachment 447297 [details]
Patch for cov#15462
Created attachment 447299 [details]
Patch for cov#15463
Created attachment 447300 [details]
Patch for cov#15464
Created attachment 447321 [details]
Patch for cov#15465
Created attachment 447336 [details]
Patch for cov#15473
Created attachment 447351 [details]
Patch for cov#15505
Created attachment 447503 [details]
Patch for cov#15506
Created attachment 447506 [details]
Patch for cov#15507
Created attachment 447508 [details]
Patch for cov#15507 & cov#15508
Created attachment 447509 [details]
Patch for cov#15509
Comment on attachment 447038 [details]
Patch for cov#11946
It looks (theoretically :) there's a case pResHash itself is NULL... (from line 256: "goto error")
Comment on attachment 447061 [details]
Revised patch for cov#11938
I was wondering if (numb > tot_b) AND (a == NULL), what would happen. But the condition is avoided by the outer while (line 1067), so I think the original code is safe. But having the check to make coverity happy should be good. :)
Comment on attachment 447321 [details]
Patch for cov#15465
Thanks!! :)
Comment on attachment 447038 [details]
Patch for cov#11946
Patch for cov#15473 covers this case...
Comment on attachment 447508 [details]
Patch for cov#15507 & cov#15508
Oops. :p Thanks!!
Pushed patches to master. Thanks to Noriko for reviewing all of the patches! Counting objects: 153, done. Delta compression using 2 threads. Compressing objects: 100% (117/117), done. Writing objects: 100% (117/117), 13.48 KiB, done. Total 117 (delta 81), reused 0 (delta 0) To ssh://git.fedorahosted.org/git/389/ds.git 9098fc7..55f94d2 master -> master Created attachment 447549 [details]
Additional patch for cov#11938
Created attachment 447566 [details]
Patch for cov#15477
Pushed the last 2 patches to master. Thanks to Rich and Noriko for the additional reviews! Counting objects: 23, done. Delta compression using 2 threads. Compressing objects: 100% (14/14), done. Writing objects: 100% (14/14), 1.54 KiB, done. Total 14 (delta 10), reused 0 (delta 0) To ssh://git.fedorahosted.org/git/389/ds.git 529b056..b83f966 master -> master Coverity Related, Can I request Dev to test this. |