Bug 630227 (ghc-convertible-text)

Summary: Review Request: ghc-convertible-text - Typeclasses and instances for converting between types
Product: [Fedora] Fedora Reporter: Ben Boeckel <fedora>
Component: Package ReviewAssignee: Nobody's working on this, feel free to take it <nobody>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: low    
Version: rawhideCC: fedora-package-review, haskell-devel, lakshminaras2002, notting
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-07-21 02:01:31 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 619991, 630224    
Bug Blocks: 630267    

Description Ben Boeckel 2010-09-04 06:10:06 UTC
Spec URL: http://benboeckel.net/packaging/ghc-convertible-text/ghc-convertible-text.spec
SRPM URL: http://benboeckel.net/packaging/ghc-convertible-text/ghc-convertible-text-0.3.0.3-1.fc14.src.rpm
Description:
This is a port of John Goerzen's convertible package,
intended to distinguish between conversions which are
guaranteed to succeed and those which might fail. It uses the
attempt package, which in turn uses the failure package, so
that this package is fully compatible with the failure
framework.

% lintmock fedora-14-x86_64-bb
ghc-convertible-text.src: W: spelling-error Summary(en_US) Typeclasses -> Type classes, Type-classes, Superclasses
ghc-convertible-text.src: W: strange-permission ghc-convertible-text.spec 0640L
ghc-convertible-text.src: W: strange-permission convertible-text-0.3.0.3.tar.gz 0640L
ghc-convertible-text.x86_64: W: spelling-error Summary(en_US) Typeclasses -> Type classes, Type-classes, Superclasses
ghc-convertible-text-devel.x86_64: W: spelling-error Summary(en_US) Typeclasses -> Type classes, Type-classes, Superclasses
ghc-convertible-text-prof.x86_64: E: devel-dependency ghc-convertible-text-devel
ghc-convertible-text-prof.x86_64: W: no-documentation
ghc-convertible-text-prof.x86_64: W: devel-file-in-non-devel-package /usr/lib64/ghc-6.12.3/convertible-text-0.3.0.3/libHSconvertible-text-0.3.0.3_p.a
4 packages and 0 specfiles checked; 1 errors, 7 warnings.

Comment 1 Ben Boeckel 2010-10-30 21:33:49 UTC
Spec URL: http://benboeckel.net/packaging/ghc-convertible-text/ghc-convertible-text.spec
SRPM URL: http://benboeckel.net/packaging/ghc-convertible-text/ghc-convertible-text-0.3.0.6-1.fc14.src.rpm

% lintmock fedora-14-x86_64-bb
ghc-convertible-text.src: W: spelling-error Summary(en_US) Typeclasses -> Type classes, Type-classes, Superclasses
ghc-convertible-text.src: W: strange-permission ghc-convertible-text.spec 0640L
ghc-convertible-text.src: W: strange-permission convertible-text-0.3.0.6.tar.gz 0640L
ghc-convertible-text.x86_64: W: spelling-error Summary(en_US) Typeclasses -> Type classes, Type-classes, Superclasses
ghc-convertible-text-devel.x86_64: W: spelling-error Summary(en_US) Typeclasses -> Type classes, Type-classes, Superclasses
ghc-convertible-text-prof.x86_64: E: devel-dependency ghc-convertible-text-devel
ghc-convertible-text-prof.x86_64: W: no-documentation
ghc-convertible-text-prof.x86_64: W: devel-file-in-non-devel-package /usr/lib64/ghc-6.12.3/convertible-text-0.3.0.6/lib
HSconvertible-text-0.3.0.6_p.a
4 packages and 0 specfiles checked; 1 errors, 7 warnings.

Comment 2 Narasimhan 2011-01-22 05:17:40 UTC
An email has been sent to the author and maintainer of the convertible-text package seeking clarification of the licensing of the package and requesting a missing file to be added.

Comment 5 Narasimhan 2011-01-29 05:48:07 UTC
Awaiting email confirmation from the previous author of the package regarding license change.

Comment 6 Narasimhan 2011-01-31 05:01:42 UTC
Mail confirmation received from John Goerzen <jgoerzen> and Michael Snoyman <michael> confirming the license change from LGPL to BSD.

Comment 7 Narasimhan 2011-03-06 01:01:01 UTC
Can you update the package with a patch containing the email from Michael? Thanks.

Comment 8 Jens Petersen 2011-06-22 01:24:28 UTC
(Just noting that object-data-json is no longer needed by authenticate.)

Comment 9 Jens Petersen 2011-10-04 00:00:51 UTC
(In reply to comment #8)
> (Just noting that object-data-json is no longer needed by authenticate.)

But data-object-yaml is needed by yesod-core anyway (and hledger-web).

http://packdeps.haskellers.com/reverse/convertible-text

Comment 10 Ben Boeckel 2012-03-03 05:42:12 UTC
Spec URL: http://benboeckel.net/packaging/ghc-convertible-text/ghc-convertible-text.spec
SRPM URL: http://benboeckel.net/packaging/ghc-convertible-text/ghc-convertible-text-0.4.0.2-1.fc18.src.rpm

ghc-convertible-text.src: W: spelling-error Summary(en_US) Typeclasses -> Type classes, Type-classes, Masterclasses
ghc-convertible-text.src: W: strange-permission ghc-convertible-text.spec 0640L
ghc-convertible-text.src: W: strange-permission convertible-text-0.4.0.2.tar.gz 0640L
ghc-convertible-text.x86_64: W: spelling-error Summary(en_US) Typeclasses -> Type classes, Type-classes, Masterclasses
ghc-convertible-text-devel.x86_64: W: spelling-error Summary(en_US) Typeclasses -> Type classes, Type-classes, Masterclasses
3 packages and 0 specfiles checked; 0 errors, 5 warnings.

Comment 11 Jens Petersen 2012-04-16 05:54:36 UTC
Missing dependency on old-time:

http://koji.fedoraproject.org/koji/taskinfo?taskID=3993339

Comment 12 Jens Petersen 2012-04-16 05:57:32 UTC
(In reply to comment #11)
> http://koji.fedoraproject.org/koji/taskinfo?taskID=3993339

Setup: At least the following dependencies are missing:
old-time >=1.0.0.2 && <1.1

Erm, sorry, I guess the old-time in ghc-7.4.1 is too new.
Maybe you can check if allowing 1.1 builds ok?

Comment 13 Narasimhan 2012-06-03 13:34:07 UTC
@Ben,
I can review this. Could you update the package as per comment 12?

Comment 14 Jens Petersen 2012-07-10 07:41:41 UTC
yesod-core-0.10 no longer needs data-object-yaml and
same for hledger-web-0.18, so I think this review can be
dropped/deferred for now.

Comment 15 Ben Boeckel 2012-07-21 02:01:31 UTC
This is marked as obsolete on Hackage. Closing.