Bug 630339
| Summary: | Review Request: python-redis - A Python client for redis | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Silas Sewell <silas> |
| Component: | Package Review | Assignee: | Ruben Kerkhof <ruben> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | low | ||
| Version: | rawhide | CC: | fedora-package-review, i, notting, ruben |
| Target Milestone: | --- | Flags: | ruben:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | python-redis-2.0.0-1.fc14 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2010-11-17 23:17:44 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Silas Sewell
2010-09-04 21:16:30 UTC
Just noticed that I accidentally posted the wrong RPM type, here is the SRPM: http://github.com/downloads/silas/rpms/python-redis-2.0.0-1.fc13.src.rpm Hi Silas,
You don't need the python_sitelib defines anymore in Fedora 13 and higher.
BuildRoot is also not needed anymore.
The same goes for %clean and rm -rf %{buildroot} in %install.
No tests, that's a pity. However I did a few tests against Redis and it works fine.
My plan is to push the package to EPEL, I'll update it for Fedora 13 after I've done that. Ok, that's fine by me. I see no further issues so this package is approved. New Package CVS Request ======================= Package Name: python-redis Short Description: A Python client for redis Owners: silas Branches: F-13 F-14 EL-5 EL-6 InitialCC: Git done (by process-git-requests). The review seems a bit terse. There isn't much to review, it's just one python script. As far as I can tell the package respects all the packaging guidelines. I can spell them all out, and put an OK behind them, like some other reviewers do, but that's just a waste of time IMHO. Of course, if you see any issues, you're always free to chime in. python-redis-2.0.0-1.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/python-redis-2.0.0-1.fc14 python-redis-2.0.0-1.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/python-redis-2.0.0-1.fc13 python-redis-2.0.0-2.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/python-redis-2.0.0-2.el5 python-redis-2.0.0-1.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update python-redis'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/python-redis-2.0.0-1.fc14 python-redis-2.0.0-2.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. python-redis-2.0.0-1.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. python-redis-2.0.0-1.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. Package Change Request ====================== Package Name: python-redis New Branches: epel7 Owners: silas cicku Git done (by process-git-requests). |