Bug 630782

I'll review it

This package also seems to be for F-15 only. Failed scratchbuild on F-14:

http://koji.fedoraproject.org/koji/taskinfo?taskID=2490108

Koji scratch build for Rawhide:

http://koji.fedoraproject.org/koji/taskinfo?taskID=2490111

REVIEW:

Legend: + = PASSED, - = FAILED, 0 = Not Applicable

+ rpmlint is silent

Sulaco ~/rpmbuild/SPECS: rpmlint ~/Desktop/meego-panel-applications-*
2 packages and 0 specfiles checked; 0 errors, 0 warnings.
Sulaco ~/rpmbuild/SPECS: 

+ The package is named according to the Package Naming Guidelines .
+ The spec file name matches the base package %{name}, in the format
%{name}.spec.
+ The package meets the Packaging Guidelines .
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines .
+ The License field in the package spec file matches the actual license (LGPLv2)
+ The file, containing the text of the license(s) for the package, is included
in %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.

+/- The package successfully compiles and builds into binary rpms on at least
one primary architecture but only in Rawhide.

+ All build dependencies are listed in BuildRequires.
+ The spec file handles locales properly.
+ The package calls ldconfig in %post and %postun.
+ The package does NOT bundle copies of system libraries.
0 The package is not designed to be relocatable.
 The package owns all directories that it creates.
+ The package does not list a file more than once in the spec file's %files
listings.

+ Permissions on files are set properly.
+ The package consistently uses macros.
+ The package contains code, or permissible content.
0 No extremely large documentation files
+ Anything, the package includes as %doc, does not affect the runtime of the
application.
0 No header files
0 No static libraries
0 No library file that end in .so (without suffix)
0 No devel sub-package
+ The package does NOT contain any .la libtool archives.

+/- The package includes a %{name}.desktop file, and that file should properly
installed with desktop-file-install in the %install section but instead it is
placed into 

%{_datadir}/mutter-meego/panels/meego-panel-applications.desktop

I don't know too much about Meego - is it intentional? 

+ The package does not own files or directories already owned by other packages.
+ All filenames in the package are valid UTF-8.


Please

* Explain whether this package is designed only for Rawhide or not
* Explain the situation with desktop file

> Please
> 
> * Explain whether this package is designed only for Rawhide or not

Currently it will only build on rawhide as MeeGo 1.0 is currently in F-14. To build it requires newer dependencies that will need to be tagged and built. Its possible I might update F-14 to MeeGo 1.1 but at the moment F-14 is targeting MeeGo 1.0.

> * Explain the situation with desktop file

The desktop file is for starting the panel applets on start. It currently contains "OnlyShowIn=X-MEEGO-NB" which isn't recognised by the fedora version of desktop-file-utils and hence can't be properly verified. As the desktop file is only used in this situation by the meego startup scripts it doesn't impact anything else but I plan on getting this fixed at a later point but it involves dealing with MeeGo, freedesktop.org and then getting all the changed pulled into Fedora.

Ok, understood now. This package is

APPROVED.

Thanks!

New Package GIT Request
=======================
Package Name: meego-panel-applications
Short Description: MeeGo Panel for launching Applications
Owners: pbrobinson
Branches: F-14
InitialCC:

Git done (by process-git-requests).

Built and headed to rawhide