Bug 630923
Summary: | TESTOUT.log is resent every 5 minutes in a whole: send only what's appended | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | [Retired] Beaker | Reporter: | Marian Csontos <mcsontos> | ||||||
Component: | beah | Assignee: | Marian Csontos <mcsontos> | ||||||
Status: | CLOSED CURRENTRELEASE | QA Contact: | |||||||
Severity: | high | Docs Contact: | |||||||
Priority: | high | ||||||||
Version: | 0.5 | CC: | bpeck, dcallagh, kbaker, mcsontos, rmancy | ||||||
Target Milestone: | --- | ||||||||
Target Release: | --- | ||||||||
Hardware: | All | ||||||||
OS: | Linux | ||||||||
Whiteboard: | |||||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | 2010-09-10 14:58:47 UTC | Type: | --- | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Bug Depends On: | |||||||||
Bug Blocks: | 632609 | ||||||||
Attachments: |
|
Description
Marian Csontos
2010-09-07 11:46:54 UTC
Testing the change. Created attachment 443493 [details]
rhts patch
Following patch works fine in el6. Testing on 3 to 5.
Hi Marian, Slight issue when run on RHEL3. https://beaker-stage.app.eng.bos.redhat.com/logs/2010/29/1429/2690/26412///TESTOUT.log /distribution/install result: PASS metric: 441 Log: /tmp/tmp.ir1820 DMesg: /tmp/dmesg.log Traceback (most recent call last): File "/usr/bin/rhts-db-submit-result", line 450, in ? main() File "/usr/bin/rhts-db-submit-result", line 398, in main (result, dmesgerrors)=check_for_errors(dmesgfile) File "/usr/bin/rhts-db-submit-result", line 305, in check_for_errors dmesg_log_file = mktemp_file() File "/usr/bin/rhts-db-submit-result", line 58, in mktemp_file (fh, f) = tempfile.mkstemp(prefix='tmp.rhts-db-submit-result.', dir='/tmp') AttributeError: 'module' object has no attribute 'mkstemp' /bin/cat: /mnt/testarea/modprobe.log: No such file or directory I'm looking to see what can be done. hmm assumed this was due to the new upload code. but I'm not sure now. Still investigating. Created attachment 445840 [details] python 2.2 incompatibility patch There is not much to investigate: documentation [1] says: > New in version 2.3. RHEL3 uses Python2.2. [1] http://docs.python.org/library/tempfile.html#tempfile.mkstemp7 Proposed patch: let python<=2.2 use mktemp and all above mkstemp. IIUC mkstemp was introduced accidentally. Forget about previous comment. I have to admit embarrassingly I was not right: - mkstemp has a purpose: mktemp does not create the file, just returns a new name. - and worse: my "fix" is not python 2.2. compatible: mktemp change was not documented. I will not rely on documentation anymore... Embracing Bill's change which I was not aware of. The fix for original issue works just fine: see J:1438, J:1439 and J:1440. I will retest the changes on el3 which is not verified yet. After some aborted jobs it's verified on el3 as well. It's all on rhts.git's origin/master now. Did you notice I already committed a patch for python2.2 to deal with mkstemp? this has been pushed |