Bug 631704

Summary: [abrt] recoll-1.13.04-6.fc13: zipfile.py:881:open:RuntimeError: File pws.png is encrypted, password required for extraction
Product: [Fedora] Fedora Reporter: Zork <redhatbugs>
Component: recollAssignee: Terje Røsten <terje.rosten>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: low    
Version: 13CC: shpnft, terje.rosten
Target Milestone: ---   
Target Release: ---   
Hardware: i686   
OS: Linux   
Whiteboard: abrt_hash:4955d9c2
Fixed In Version: recoll-1.14.2-2.fc13 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2010-11-24 22:41:09 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
File: backtrace none

Description Zork 2010-09-08 08:32:05 UTC
abrt version: 1.1.13
architecture: i686
cmdline: python /usr/share/recoll/filters/rclzip
component: recoll
executable: /usr/share/recoll/filters/rclzip
kernel: 2.6.34.6-47.fc13.i686
package: recoll-1.13.04-6.fc13
reason: zipfile.py:881:open:RuntimeError: File pws.png is encrypted, password required for extraction
release: Fedora release 13 (Goddard)
time: 1283928602
uid: 500

backtrace
-----
zipfile.py:881:open:RuntimeError: File pws.png is encrypted, password required for extraction

Traceback (most recent call last):
  File "/usr/share/recoll/filters/rclzip", line 52, in <module>
    e.mainloop(ZipExtractor(e))
  File "/usr/share/recoll/filters/rclexecm.py", line 116, in mainloop
    self.processmessage(processor, params)
  File "/usr/share/recoll/filters/rclexecm.py", line 93, in processmessage
    ok, data, ipath, eof = processor.getnext(params)
  File "/usr/share/recoll/filters/rclzip", line 47, in getnext
    ret= self.extractone(self.zip.namelist()[self.currentindex])
  File "/usr/share/recoll/filters/rclzip", line 20, in extractone
    docdata = self.zip.read(ipath)
  File "/usr/lib/python2.6/zipfile.py", line 831, in read
    return self.open(name, "r", pwd).read()
  File "/usr/lib/python2.6/zipfile.py", line 881, in open
    "password required for extraction" % name
RuntimeError: File pws.png is encrypted, password required for extraction

Local variables in innermost frame:
zef_file: <open file '/home/user/data/pws.png.zip', mode 'rb' at 0x8fe2ac0>
name: 'pws.png'
zd: None
self: <zipfile.ZipFile instance at 0x9008f6c>
is_encrypted: 1
fheader: ('PK\x03\x04', 20, 0, 9, 8, 13173, 15222, 1522365260, 124878, 139127, 7, 21)
zinfo: <zipfile.ZipInfo object at 0x8fde20c>
pwd: None
mode: 'r'
fname: 'pws.png'

comment
-----
Generates runtime error and initiates Automatic Bug Reporting Tool but appears to continue and finish the indexing.
Expected action is ignore or note encrypted file without runtime error.

How to reproduce
-----
1. Have zip file with encrypted files.
2. Setup recollindex (from recoll package) on cron job.
3. recollindex finds encrypted zip file.  Uses  python /usr/share/recoll/filters/rclzip  and generates runtime error.

Comment 1 Zork 2010-09-08 08:32:07 UTC
Created an attachment (id=445921)
File: backtrace

Comment 2 Terje Røsten 2010-11-07 19:16:51 UTC
Thanks for your report. 

Could you please test recoll 1.14.2 and check if the bug is fixed?

Updated package available here:
 https://admin.fedoraproject.org/updates/recoll-1.14.2-1.fc13

Comment 3 Rodrigo de Farias Gomes 2010-11-13 00:20:24 UTC
(In reply to comment #2)
> Thanks for your report. 
> 
> Could you please test recoll 1.14.2 and check if the bug is fixed?
> 
> Updated package available here:
>  https://admin.fedoraproject.org/updates/recoll-1.14.2-1.fc13

Hello,
I tested and the bug is not fixed yet.

How I test:
1. touch foo bar
2. zip --encrypt teste.zip foo bar
3. cp teste.zip /media/old_home (directory indexed by recoll)
4. recollindex

The command recollindex return the error:

Traceback (most recent call last):
  File "/usr/share/recoll/filters/rclzip", line 52, in <module>
    e.mainloop(ZipExtractor(e))
  File "/usr/share/recoll/filters/rclexecm.py", line 117, in mainloop
    self.processmessage(processor, params)
  File "/usr/share/recoll/filters/rclexecm.py", line 94, in processmessage
    ok, data, ipath, eof = processor.getnext(params)
  File "/usr/share/recoll/filters/rclzip", line 47, in getnext
    ret= self.extractone(self.zip.namelist()[self.currentindex])
  File "/usr/share/recoll/filters/rclzip", line 20, in extractone
    docdata = self.zip.read(ipath)
  File "/usr/lib/python2.6/zipfile.py", line 831, in read
    return self.open(name, "r", pwd).read()
  File "/usr/lib/python2.6/zipfile.py", line 881, in open
    "password required for extraction" % name
RuntimeError: File foo is encrypted, password required for extraction

and the abrt is called.

Sorry by bad spelling and grammar, english is not my native language.

Comment 4 Fedora Update System 2010-11-15 17:30:04 UTC
recoll-1.14.2-2.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/recoll-1.14.2-2.fc13

Comment 5 Fedora Update System 2010-11-15 17:30:15 UTC
recoll-1.14.2-2.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/recoll-1.14.2-2.fc14

Comment 6 Fedora Update System 2010-11-16 23:16:48 UTC
recoll-1.14.2-2.fc13 has been pushed to the Fedora 13 testing repository.  If problems still persist, please make note of it in this bug report.
 If you want to test the update, you can install it with 
 su -c 'yum --enablerepo=updates-testing update recoll'.  You can provide feedback for this update here: https://admin.fedoraproject.org/updates/recoll-1.14.2-2.fc13

Comment 7 Rodrigo de Farias Gomes 2010-11-18 13:48:37 UTC
Hello,
the bug is fixed.

How I test:
1. touch foo bar
2. zip --encrypt teste.zip foo bar
3. cp teste.zip /media/old_home (directory indexed by recoll)
4. recollindex

and abrt is not called. Thanks for the fix.

Again, sorry by bad spelling and grammar...

Comment 8 Fedora Update System 2010-11-24 22:41:01 UTC
recoll-1.14.2-2.fc14 has been pushed to the Fedora 14 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2010-11-24 22:41:50 UTC
recoll-1.14.2-2.fc13 has been pushed to the Fedora 13 stable repository.  If problems still persist, please make note of it in this bug report.