Bug 632190
Summary: | Review Request: erlang-amf - Erlang Action Message Format Library | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Peter Lemenkov <lemenkov> |
Component: | Package Review | Assignee: | Peter Robinson <pbrobinson> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | fedora-package-review, notting, pbrobinson |
Target Milestone: | --- | Flags: | pbrobinson:
fedora-review+
kevin: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | erlang-amf-0-0.2.20100908git27329144.el5 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2010-10-08 12:41:51 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Peter Lemenkov
2010-09-09 11:17:57 UTC
New package: http://peter.fedorapeople.org/erlang-amf.spec http://peter.fedorapeople.org/erlang-amf-0-0.2.20100908git27329144.fc12.src.rpm %changelog - Narrowed BuildRequires. Koli scratchbuild for F-13: http://koji.fedoraproject.org/koji/taskinfo?taskID=2489895 + rpmlint output rpmlint erlang-amf-0-0.2.20100908git27329144.fc14.x86_64.rpm erlang-amf.x86_64: E: explicit-lib-dependency erlang-stdlib erlang-amf.x86_64: E: no-binary erlang-amf.x86_64: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 2 errors, 1 warnings. + package name satisfies the packaging naming guidelines + specfile name matches the package base name + package should satisfy packaging guidelines + license meets guidelines and is acceptable to Fedora + license matches the actual package license + latest version packaged + %doc includes license file + spec file written in American English + spec file is legible + upstream sources match sources in the srpm 168ce4e25fac6c77e8a5dde262a7c6df mujaheed-erlang-amf-2732914.tar.gz + package successfully builds on at least one architecture tested using koji scratch build + BuildRequires list all build dependencies n/a %find_lang instead of %{_datadir}/locale/* n/a binary RPM with shared library files must call ldconfig in %post and %postun+ does not use Prefix: /usr n/a package owns all directories it creates n/a no duplicate files in %files + Package perserves timestamps on install + Permissions on files must be set properly + %defattr line + consistent use of macros + package must contain code or permissible content n/a large documentation files should go in -doc subpackage + files marked %doc should not affect package runtime n/a header files should be in -devel n/a static libraries should be in -static n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig' n/a libfoo.so must go in -devel n/a devel must require the fully versioned base + packages should not contain libtool .la files n/a packages containing GUI apps must include %{name}.desktop file + packages must not own files or directories owned by other packages + filenames must be valid UTF-8 Optional: + if there is no license file, packager should query upstream to include it n/a translations of description and summary for non-English languages, if available + reviewer should build the package in mock/koji n/a the package should build into binary RPMs on all supported architectures n/a review should test the package functions as described + scriptlets should be sane n/a non -devel packages should require fully versioned base n/a pkgconfig files should go in -devel + shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or /usr/sbin n/a Package should have man files Looks fine. APPROVED! Also note there's not need for BuilRoot: anymore (unless you need to support older systems). Thanks! New Package SCM Request ======================= Package Name: erlang-amf Short Description: Erlang Action Message Format Library Owners: peter Branches: f12 f13 f14 el6 el5 InitialCC: Git done (by process-git-requests). erlang-amf-0-0.2.20100908git27329144.fc12 has been submitted as an update for Fedora 12. https://admin.fedoraproject.org/updates/erlang-amf-0-0.2.20100908git27329144.fc12 erlang-amf-0-0.2.20100908git27329144.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/erlang-amf-0-0.2.20100908git27329144.el5 erlang-amf-0-0.2.20100908git27329144.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/erlang-amf-0-0.2.20100908git27329144.fc13 erlang-amf-0-0.2.20100908git27329144.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/erlang-amf-0-0.2.20100908git27329144.fc14 erlang-amf-0-0.2.20100908git27329144.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update erlang-amf'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/erlang-amf-0-0.2.20100908git27329144.fc14 erlang-amf-0-0.2.20100908git27329144.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. erlang-amf-0-0.2.20100908git27329144.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. erlang-amf-0-0.2.20100908git27329144.fc12 has been pushed to the Fedora 12 stable repository. If problems still persist, please make note of it in this bug report. erlang-amf-0-0.2.20100908git27329144.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. |