Bug 633035

Summary: [RFE] Exception handling clean-up
Product: Red Hat Enterprise Linux 6 Reporter: Saggi Mizrahi <smizrahi>
Component: vdsmAssignee: Ayal Baron <abaron>
Status: CLOSED NOTABUG QA Contact: yeylon <yeylon>
Severity: medium Docs Contact:
Priority: low    
Version: 6.0CC: abaron, bazulay, danken, iheim, Rhev-m-bugs, srevivo, ykaul
Target Milestone: rcKeywords: CodeChange, FutureFeature, Improvement
Target Release: ---   
Hardware: All   
OS: Linux   
Fixed In Version: Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-02-24 03:25:27 EST Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Description Saggi Mizrahi 2010-09-12 10:58:30 EDT
Description of problem:
There are places where we catch Exception where we really mean to catch generic exceptions. This should be change to only catch expected exceptions. That way when an unexpected exception is thrown we can quickly tell what is the problem.

In cases where we need to clean up in any case. Don't mask the exception, Reraise after cleanup.

String exceptions are illegal in 2.6 thus we can get rid of all the empty excepts. Places that catch Exception and empty should be mended to only catch Exception.

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
Actual results:

Expected results:

Additional info: